Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Linting]: Lint practice stub files (2 / ?) #2789

Merged
merged 17 commits into from
Nov 18, 2021
Merged

[Linting]: Lint practice stub files (2 / ?) #2789

merged 17 commits into from
Nov 18, 2021

Conversation

J08K
Copy link
Member

@J08K J08K commented Nov 18, 2021

According to issue #2582.

@J08K J08K added the x:size/large Large amount of work label Nov 18, 2021
@J08K J08K requested a review from BethanyG November 18, 2021 09:28
@J08K J08K self-assigned this Nov 18, 2021
@J08K
Copy link
Member Author

J08K commented Nov 18, 2021

Sigh, some stupid commit things, let me fix.

J08K
J08K commented Nov 18, 2021
View reviewed changes
exercises/practice/affine-cipher/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/affine-cipher/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/affine-cipher/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/atbash-cipher/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/beer-song/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/bob/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/bob/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/bob/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/bob/.meta/example.py Outdated Show resolved Hide resolved
exercises/practice/bob/.meta/example.py Outdated Show resolved Hide resolved
@J08K
Copy link
Member Author

J08K commented Nov 18, 2021

Sigh, sorry about the extra files.

BethanyG
BethanyG approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🌟 Thank you. 😄

@BethanyG
Copy link
Member

@J08K -- so so sorry to do this to you. I think you are going to have to do a fetch and a rebase on this branch locally and then re-push. I can't rebase and merge from this side. 😞

@J08K
Copy link
Member Author

J08K commented Nov 18, 2021

They seem to be fine to me, I can't see what's going on.

@J08K J08K requested a review from BethanyG November 18, 2021 21:06
@J08K J08K merged commit 816942b into main Nov 18, 2021
@J08K J08K deleted the J08K-Linting branch November 18, 2021 21:22
@J08K J08K restored the J08K-Linting branch November 18, 2021 21:23
@J08K J08K deleted the J08K-Linting branch November 18, 2021 21:23
@J08K J08K restored the J08K-Linting branch November 18, 2021 21:23
@J08K J08K deleted the J08K-Linting branch November 18, 2021 21:23
J08K added a commit that referenced this pull request Nov 18, 2021
@J08K
Revert "[Linting]: Lint practice stub files (2 / ?) (#2789)"
eadfa85 
This reverts commit 816942b.
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyG BethanyG Awaiting requested review from BethanyG

Assignees

@J08K J08K

Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@J08K @BethanyG