Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New classes concept exercise]: ellens-alien-game #2876

Merged
merged 50 commits into from
Feb 17, 2022
Merged

[New classes concept exercise]: ellens-alien-game #2876

merged 50 commits into from
Feb 17, 2022

Conversation

PaulT89
Copy link
Contributor

@PaulT89 PaulT89 commented Jan 24, 2022 •
edited
Loading

BethanyG's Note: This PR is for a concept exercise introducing classes. See #2349 for more details/discussion.

Introduces the concept of classes.
Introduction.md is empty
Design.md is empty

(Update: Other Notes)
I should probably also mention that there are no 'General' hints yet. Not sure if that's important.

(edited to add checklist)

  • config.json & UUID for exercise
  • introduction.md
  • design.md
  • instructions.md
  • hints.md
  • links.json
  • .meta/exemplar.py
  • Added exercise icon to .meta/config.json file
  • Formatted .meta/config.json file
  • classes_test.py (tests)
  • classes.py (stub file)
  • Formatted config.json file
  • Spelling, language, and punctuation (needs a final check)

@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@BethanyG
Copy link
Member

@IsaacG -- This PR was a WIP, and should not have been reviewed for things like punctuation, etc. In future, please wait for a maintainer to go through a PR for content or subject matter before nit-picking language, formatting or style. Reviewing for detail before content adds noise and confusion as to what should be done to make a larger PR (like a new concept exercise) ready for release. Thanks!

@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@exercism exercism deleted a comment from IsaacG Jan 25, 2022
@BethanyG BethanyG self-requested a review January 25, 2022 04:45
@BethanyG BethanyG changed the title New concept exercise: ellens-alien-game [New classes concept exercise]: ellens-alien-game Jan 25, 2022
BethanyG
BethanyG reviewed Jan 25, 2022
View reviewed changes
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulT89 -- I think this is an excellent first pass! 🌟 I am going stop with the edits/feedback for this round - The GitHub UI is getting flakey on me, and I think there is a lot already here for you to process. The test file still needs some additional feedback -- but it can wait until we get some other things sorted. Thank you again for all of your hard work on this -- it's great. Let me know if you have questions or issues - or if you need anything.

config.json Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/.docs/instructions.md Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/alien_class_test.py Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/alien_class_test.py Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/alien_class_test.py Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/alien_class_test.py Outdated Show resolved Hide resolved
exercises/concept/ellens-alien-game/alien_class_test.py Outdated Show resolved Hide resolved
@PaulT89 PaulT89 marked this pull request as draft January 25, 2022 12:29
@PaulT89 PaulT89 marked this pull request as ready for review January 25, 2022 12:31
@PaulT89 PaulT89 closed this Jan 26, 2022
PaulT89 and others added 10 commits January 26, 2022 06:12
@PaulT89
New concept exercise: ellens-alien-game
e165ac3 
Introduces the concept of classes.
Message-Id: <20220126095726.46310-2-keeperotphones+patch@gmail.com>
@PaulT89
Update config.json
8b396ec 
Message-Id: <71aad1e9fc012ef13fa5c02ceb4e3ec349715d85.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <bc2601f32a9d9247ac2f767d1f4267f340a22ec6.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89
Delete introduction-draft.md
7646897 
Message-Id: <d11b031b5ef068658b9e2b1efa882a75c2ba70c5.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <f61ad700909f434f38fb55076ab4dc4d9258a6ab.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89
Create introduction
349a580 
Message-Id: <938209240cdbc86bbddc5c33403659a290ec55ac.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <ca99353a7426f0bea05df556cc19752edf48ffce.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89
Rename introduction to introduction.md
b3147c4 
Message-Id: <4373a3b66fac460701b429d22c76cd33d8b7db4a.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <c675ca900a18a3ad9f8a6b48cdad1157ea312321.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89
Update and rename design-draft.md to design.md
a10beaa 
Message-Id: <c863549b1a61dc045162be8d6d42ae9a505cddd1.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <71b06afa96db6e5b6dde815560a5776bc8368e8f.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89
Fixed typo in instructions.md
238362a 
Message-Id: <21826fc58f9cfa53d61e6e3ccf5fcc30e6d9e411.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <88a24ed3e8685ba96fdf26bb4c0629131272281f.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89 @BethanyG
Formatting with YAPF
38b1943 
Confirmed with pylint and flake8.

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Message-Id: <ec52cd798d671348f5b29c0a691155d072c023af.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <58b93bb2ed0919c3e5753e25228bcc175a24edfa.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89 @BethanyG
Update config.json
40741ae 
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Message-Id: <467259ba695c8005f7106d1f359b1d4fe6c14562.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <29a418465a89c10dfd711475da4236932c4e8eff.1643195691.git.keeperotphones+patch@gmail.com>
@PaulT89 @BethanyG
Update exercises/concept/ellens-alien-game/.meta/config.json
d5cf099 
We'll need to rename the files though

Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Message-Id: <933195ff036507b273b55633b40a7b76cc27f130.1643189851.git.keeperotphones+patch@gmail.com>
Message-Id: <529e34d1258c17b00e20278430682cd237cae6a7.1643195691.git.keeperotphones+patch@gmail.com>
@BethanyG
Apply suggestions from code review
d39229e 
Fixed a few typos and added missing code block in introduction.
@BethanyG
Added additional resources to links.json
2ed9675 
* Added Python Morsels and Dan Bader
* Added links on static vs class methods
* Added link on history of New Style classes in python.
BethanyG
BethanyG approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulT89 -- I think at loooooong last, **we are there!!* 🌟 🌈
I've approved this -- but will put a hold on it and wait for you to give it one last read-through and check before we merge it in. 😄 Thank you so much for your excellent work on this!

@BethanyG BethanyG added x:size/large Large amount of work do not merge 🚧 Don't merge until this label is removed. labels Feb 16, 2022
@PaulT89
Added links + fixed typos
38d9c09 
Added link to:
- Official Python Classes tutorial page
- The DO tutorial article already linked in the exercise introduction (and as a resource in design.md)
- A subsequent DO tutorial article focusing specifically on class and instance variables
@PaulT89
Fixed typos
e9789e5
@PaulT89
General Cleaning
31eb5f4 
Reworded clumsy sentences, deleted whitespace, fixed typos, removed some back-quotes to improve consistency with other documentation.
@PaulT89
Fixed typos + removed whitespace
4108002
@PaulT89
Copy link
Contributor Author

PaulT89 commented Feb 17, 2022

Okay, I'm happy. Carefully reading through it, I found a bunch of spelling mistakes - my spell-checker didn't pick them up because they were all in the comments within the code-blocks - and I think I got them all (but, admittedly, I might have missed some, as most were in both about.md and the exercise introduction.md). Added 3 links to links.json, re-read the instructions.md & hints.md and fixed a few clumsy sentences and inconsistencies. That's about it really. Good to go. 👍

@PaulT89
Copy link
Contributor Author

PaulT89 commented Feb 17, 2022

Oh, and what happens to the "wip" tag in the main config.json file? Does that need to come off or do we keep that on for now?

@BethanyG
Copy link
Member

BethanyG commented Feb 17, 2022 •
edited
Loading

@PaulT89 - WOOOT! 🌟

Oh, and what happens to the "wip" tag in the main config.json file? Does that need to come off or do we keep that on for now?

Per our earlier discussion on this PR, we're going to keep the status WIP for now as we merge. 😄 We'll update to Beta after a feedback period.

@IsaacG -- Now would be the time (if you have time and are willing) to go through the exercise, create a solution, and put together an issue on what you think needs changing or adding. The original issue for this exercise is here, which includes the topics covered, etc. I think it might be cleanest to do a brand-new "feedback on Ellens Alien Game" issue linking this PR and the original. And thank you for any feedback you'd like to give!

@BethanyG BethanyG merged commit 6c3bdd8 into exercism:main Feb 17, 2022
@kotp
Copy link
Member

kotp commented Feb 17, 2022

I think we can remove the "Do Not Merge" Label, or someone might think to revert this as a mistaken merge.

@BethanyG BethanyG removed the do not merge 🚧 Don't merge until this label is removed. label Feb 18, 2022
This was referenced Jul 14, 2022
Merged
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaacG IsaacG IsaacG left review comments

@BethanyG BethanyG BethanyG approved these changes

Assignees
No one assigned
Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PaulT89 @BethanyG @IsaacG @iHiD @kotp