-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[class-inheritance] Concept Documentation #2960
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Hi @girijakar 👋🏽 Thank you for submitting this PR. 😄 Were you intending to do a PR for issue #2350? There appears to be a lot of information about class members in this particular about doc that should go with The about docs for this concept -
Additionally, the concept introduction doc is missing from the set. It should be brief introduction to the concept topic. Are you also going to work on the exercise for this concept? Both issue #2350 and #2351 are for concept exercises as opposed to concept docs -- although the concept docs can be submitted as part of the concept exercise. Please let me know -- and if you are only working on the concept docs, I will write up a new issue for you. |
I have set this to draft as it is not yet ready for review.
Yes.
If you can think of at least 1 or 2, place them in the documentation. This can grow as you develop the documentation, I am sure you will realize other uses as it gets fleshed out. Thank you for working on this! |
OK, but introduction.md doc is there in the set. |
@girijakar - So it is! My apologies for missing it! I will give this a more through read-through in the morning my time (I'm in the pacific time zone). will you also be submitting the exercise portion of the issue in this PR or a follow on PR -- or are you only wanting to work on the concept as opposed to the exercise? |
@BethanyG I want to work on the concept only for now ☺ |
@girijakar - apologies for the delay! I've opened a new issue that covers just the concept documents. It's #2972. I've linked this PR to it. |
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@BethanyG Today I've commited your suggestions. Soon will work on rearranging/rewording/removing the concepts. |
@girijakar - That's awesome news! Thanks so much for working on this. I am a bit swamped with work, but will make sure to give this a good look over the weekend. |
@girijakar are you still working on this? Given its age, I am going to "optimistically merge" this as-is, and if you wish to continue working on revisions, you can submit a follow-on PR. Just ping and let us know. I will file an improvement issue for these docs, and you are more than welcome to then pick that up. Thanks again for all your work on this! 💙 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optimistically merging.
Concept documentation for issue
#2351#2972