-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Update Concept] functions, and complete function arguments #3067
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bobahop This is great! Thank you so much for revising this and moving it forward. 💙 I've left a bunch of little nits. The only "required" change I'd request is that we use REPL formatting for these small code examples. I'd also add something in here somewhere about Python being an OOP language, and so functions are objects. Beyond that, this looks really good.
Added links for def, argument, parameter, return. Changed links for global and nonlocal, since they no longer pointed to their specific subject. Minor formatting, phrasing and spelling tweaks.
NEVERMIND. I forgot this was the intro. I think this stuff is better in |
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Thank you for REPLing the examples. If I had seen the About.md first I might have done that. |
Saving work. More to come...
Saving work
Saving work. More to come...
Saving work. More to come...
Saving work. More to come...
Saving work. More to come...
Saving work. More to come...
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@BethanyG , thank you for adding the default arguments section! I conflated them with keyword arguments, but they deserve their own section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Some last suggestions. Beyond these, I think we need a better local -> nonlocal -> global code example progression, but I couldn't suggest one in the interface. But after that, this is good to go.
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to approve this so we can merge it and work on a cleaner copy. Points we still need to address:
- We need to remove the code examples for
global
andnonlocal
and redo them for clarity. - There may be some formatting issues that have crept in. If so, we'll need to address them in a follow-on PR.
Updating the functions concept to prepare for the functions concept exercise. This includes completing the function arguments concept, which is currently TODO. Function arguments will be lightly covered in functions, but a link to the function arguments concept will be provided, so something should be in there, I think.