Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update Concept] functions, and complete function arguments #3067

Merged
merged 87 commits into from
Jun 3, 2022

Conversation

bobahop
Copy link
Member

@bobahop bobahop commented May 26, 2022

Updating the functions concept to prepare for the functions concept exercise. This includes completing the function arguments concept, which is currently TODO. Function arguments will be lightly covered in functions, but a link to the function arguments concept will be provided, so something should be in there, I think.

@github-actions

This comment was marked as resolved.

Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bobahop This is great! Thank you so much for revising this and moving it forward. 💙 I've left a bunch of little nits. The only "required" change I'd request is that we use REPL formatting for these small code examples. I'd also add something in here somewhere about Python being an OOP language, and so functions are objects. Beyond that, this looks really good.

concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
concepts/functions/introduction.md Outdated Show resolved Hide resolved
@BethanyG BethanyG added the x:rep/large Large amount of reputation label May 26, 2022
Added links for def, argument, parameter, return. Changed links for global and nonlocal, since they no longer pointed to their specific subject. Minor formatting, phrasing and spelling tweaks.
@BethanyG
Copy link
Member

BethanyG commented May 26, 2022

🤦🏽‍♀️ I also forgot .. we probably need to mention scoping/namespacing in here somewhere......

NEVERMIND. I forgot this was the intro. I think this stuff is better in about.md anyways. 😄

bobahop and others added 8 commits May 26, 2022 15:47
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@bobahop
Copy link
Member Author

bobahop commented May 26, 2022

Thank you for REPLing the examples. If I had seen the About.md first I might have done that.

@bobahop bobahop self-assigned this Jun 2, 2022
concepts/function-arguments/about.md Outdated Show resolved Hide resolved
concepts/function-arguments/about.md Outdated Show resolved Hide resolved
concepts/function-arguments/about.md Outdated Show resolved Hide resolved
concepts/function-arguments/about.md Outdated Show resolved Hide resolved
concepts/function-arguments/about.md Show resolved Hide resolved
concepts/function-arguments/about.md Outdated Show resolved Hide resolved
concepts/function-arguments/about.md Outdated Show resolved Hide resolved
concepts/function-arguments/about.md Show resolved Hide resolved
bobahop and others added 7 commits June 3, 2022 08:31
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@bobahop
Copy link
Member Author

bobahop commented Jun 3, 2022

@BethanyG , thank you for adding the default arguments section! I conflated them with keyword arguments, but they deserve their own section.

Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Some last suggestions. Beyond these, I think we need a better local -> nonlocal -> global code example progression, but I couldn't suggest one in the interface. But after that, this is good to go.

concepts/functions/about.md Outdated Show resolved Hide resolved
concepts/functions/about.md Outdated Show resolved Hide resolved
concepts/functions/about.md Outdated Show resolved Hide resolved
concepts/functions/about.md Outdated Show resolved Hide resolved
concepts/functions/about.md Outdated Show resolved Hide resolved
bobahop and others added 5 commits June 3, 2022 10:40
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
@bobahop bobahop marked this pull request as ready for review June 3, 2022 15:55
@BethanyG BethanyG self-requested a review June 3, 2022 15:59
Copy link
Member

@BethanyG BethanyG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to approve this so we can merge it and work on a cleaner copy. Points we still need to address:

  1. We need to remove the code examples for global and nonlocal and redo them for clarity.
  2. There may be some formatting issues that have crept in. If so, we'll need to address them in a follow-on PR.

concepts/functions/about.md Show resolved Hide resolved
concepts/functions/about.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants