dibs: implement binary-search-tree

[laurauzcategui]

I will implement binary-search-tree in : Binary Search Tree - X-Common

[kytrinyx]

Thanks so much for working on this ❤️

It looks like you're still working on getting the test suite implemented. If you want to have a look at some of the other implementations of this exercise, you can check out:

• https://github.com/exercism/xcsharp/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xclojure/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xcoffeescript/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xecmascript/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xfsharp/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xgo/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xhaskell/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xjavascript/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xlua/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xperl5/tree/master/binary-search-tree
• https://github.com/exercism/xruby/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xscala/tree/master/exercises/binary-search-tree
• https://github.com/exercism/xswift/tree/master/exercises/binary-search-tree

[laurauzcategui]

Hi @behrtam @kytrinyx,

Could you do quick review ?

Cheers,

[laurauzcategui]

Also @behrtam ,

I think as I rebased the upstream, I brought your changes from there to my branch. I hope this is not a problem. Just wanted to update my branch with latest changes from the upstream

[arcuru]

Requiring an initial value for the BST seems like a very odd design choice...

[arcuru]

You already wrote this function below. self.pre_insert(self.root, new_val)

[arcuru]

This search function is probably a little easier to read if you do something like this:

cur = self.root
while cur:
    if find_val == cur.value:
        return True
    cur = cur.left if find_val < cur.value else cur.right
return False

[arcuru]

@laurauzcategui You can clean up the extra git commits by resetting instead of rebasing. It's explained here - https://github.com/exercism/x-common/blob/master/CONTRIBUTING.md#resetting-master

You also need to add a few more tests. Right now you only ever test inserting things into the left nodes. You should at least add some tests to try to insert a more complex tree and values that are already in the tree.

[laurauzcategui]

Thanks @patricksjackson will check it over the weekend 👍

[stale]

This issue has been automatically marked as `on hiatus because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[kytrinyx]

@laurauzcategui Would you have a chance to finish this one up? We'd love to include it on the site.

[laurauzcategui]

Hi @kytrinyx yes, sure thing. I'll be able to take a look probably next week and over the weekend.

Cheers,

[stale]

This issue has been automatically marked as on hiatus because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[devkabiir]

@kytrinyx Looks like issue was automatically closed, but I have a BST implementation ready in python2 I would like to include this exercise. Can you assign this issue to me and add hacktoberfest label too?

[kytrinyx]

@kabiir that's great. Please submit your pull request. It doesn't need to have an open issue or a hacktoberfest label in order to be counted towards your Hacktoberfest metrics.