atbash_cipher_test: Add 2 tests #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `test_decode_number` as there is a test that encode number. Check this _iteration_[1] for a solution that pass the tests without checking for alphanumeric in decode. Add `test_encode_decode`. Having done this in the first place, would had highlighted the need of checking for alphanumeric in decoding. [1] http://exercism.io/submissions/c7c9448e6a674dd6a11ea35dc32e29a4
behrtam
approved these changes
Feb 23, 2017
There was a problem hiding this comment.
Looks good to me! Decode numbers some how got overlooked as it is part of the canonical test data: https://github.com/exercism/x-common/blob/master/exercises/atbash-cipher/canonical-data.json#L66-L68
ErikSchierboom
added a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 21, 2021
* Create common working area * Extract Concepts from v2 exercise: reverse-string (exercism#657) * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity (exercism#503) * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree (exercism#501) * Add initial list (exercism#463) First pass concepts for `allergies` to address exercism#460 * Initial list of concepts (exercism#462) First pass list of concepts to address exercism#459 * Add Concepts for v2 exercise: phone-number (exercism#420) * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming (exercism#418) * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. (exercism#395) * Extract Concepts from v2 exercise: markdown (exercism#540) * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix (exercism#416) * `matrix` exercise concepts (issue exercism#386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match exercism#290 Formatting Edited concepts to better match the formatting of issue exercism#290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription (exercism#520) * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator (exercism#538) * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions (exercism#665) * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 (exercism#705) * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification (exercism#793) * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom
added a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 22, 2021
* Create common working area * Extract Concepts from v2 exercise: reverse-string (exercism#657) * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity (exercism#503) * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree (exercism#501) * Add initial list (exercism#463) First pass concepts for `allergies` to address exercism#460 * Initial list of concepts (exercism#462) First pass list of concepts to address exercism#459 * Add Concepts for v2 exercise: phone-number (exercism#420) * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming (exercism#418) * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. (exercism#395) * Extract Concepts from v2 exercise: markdown (exercism#540) * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix (exercism#416) * `matrix` exercise concepts (issue exercism#386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match exercism#290 Formatting Edited concepts to better match the formatting of issue exercism#290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription (exercism#520) * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator (exercism#538) * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions (exercism#665) * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 (exercism#705) * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification (exercism#793) * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom
added a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 26, 2021
* Create common working area * Extract Concepts from v2 exercise: reverse-string (exercism#657) * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity (exercism#503) * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree (exercism#501) * Add initial list (exercism#463) First pass concepts for `allergies` to address exercism#460 * Initial list of concepts (exercism#462) First pass list of concepts to address exercism#459 * Add Concepts for v2 exercise: phone-number (exercism#420) * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming (exercism#418) * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. (exercism#395) * Extract Concepts from v2 exercise: markdown (exercism#540) * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix (exercism#416) * `matrix` exercise concepts (issue exercism#386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match exercism#290 Formatting Edited concepts to better match the formatting of issue exercism#290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription (exercism#520) * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator (exercism#538) * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions (exercism#665) * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 (exercism#705) * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification (exercism#793) * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
ErikSchierboom
added a commit
to ErikSchierboom/python
that referenced
this pull request
Jan 27, 2021
* Create common working area * Extract Concepts from v2 exercise: reverse-string (exercism#657) * Create reverse-string.md * Update reverse-string.md * Add Concepts from v2 exercise: variable-length-quantity (exercism#503) * Add first concepts group * Improved concepts as per PR review * Adds concept from binary-search-tree (exercism#501) * Add initial list (exercism#463) First pass concepts for `allergies` to address exercism#460 * Initial list of concepts (exercism#462) First pass list of concepts to address exercism#459 * Add Concepts for v2 exercise: phone-number (exercism#420) * Add phone-number Python concepts * Small update to index access and slice topics. * Add notes from review. - more information about classes, inheritance - flesh out privacy, public and non-public - clarify wording around iterables and index/slice access * One more note about brackets and strings. * Add Concepts for v2 exercise: hamming (exercism#418) * Add concepts for hamming * Add note about tuple unpacking. * Add notes about polymorphism, builtins, and dunder methods. * Some whitespace fixes. * [WIP] `clock` exercise concepts. (exercism#395) * Extract Concepts from v2 exercise: markdown (exercism#540) * Initial commit for markdown exercise concepts. * Concept starter for markdown * Added detail to Markdown concepts * Final edits before harmonization Final Markdown edits before we merge and harmonize. * Add Concepts for v2 exercise: matrix (exercism#416) * `matrix` exercise concepts (issue exercism#386) First pass of concepts for `matrix ` exercise in python. Pretty sure this is too detailed, but wanted to get something for review before proceeding with additional exercises. * Edits to better match exercism#290 Formatting Edited concepts to better match the formatting of issue exercism#290 * Typo correction * added title * Extract Concepts from v2 exercise: rna-transcription (exercism#520) * Beginning of Concepts for rna-transcription * More detailed concepts for rna-trranscription More detailed concepts for rna-transcription exrcise. * Added title * Extract Concepts from v2 exercise: robot-simulator (exercism#538) * Beginning of concepts for robot-simulator. * WIP Concepts * Additional detail for concepts * Detail third pass Third pass on adding concept detail. * Additional detail for concepts. * Edits per PR Feedback Numerous spelling corrections. Additional edits to address comments from last review. * [WIP] Concept implementation instructions (exercism#665) * Adds instructions for exercise implementation * Adds correction as per PR reviews * Harmonize, part 1 (exercism#705) * fix relative links in references/README.md * First pass at harmonization Shifts all documents to a common format, adds minimal link tagging to the "concept" currently listed in each file. These will really need multiple more passes, as they diverge from each other even when describing the same topic. Many extraneous topics have crept in, added in an "aspirational" fashion to the exercises; we may need to trim some of that. * Pulling in examples from BethanyG * [WIP] Extracted concept unification (exercism#793) * Unification of extracted concepts * Typos and duplicates remove * Duplicates concept unification * Concepts have now links to original file * Update languages/reference/README.md Co-Authored-By: Erik Schierboom <erik_schierboom@hotmail.com> Co-authored-by: khoivan88 <33493502+khoivan88@users.noreply.github.com> Co-authored-by: David G <davidgerva@gmail.com> Co-authored-by: Ashley Drake <a.l.drake713@gmail.com> Co-authored-by: Pedro Romano <pedro@paparomeo.net> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com> Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
test_decode_numberas there is a test that encode number. Check this iteration[1] for a solution that pass the tests without checking for alphanumeric in decode.Add
test_encode_decode. Having done this in the first place, would had highlighted the need of checking for alphanumeric in decoding.[1] http://exercism.io/submissions/c7c9448e6a674dd6a11ea35dc32e29a4