Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello-world: Simplify to unconditional "Hello, World!" #432

Merged
merged 1 commit into from
Mar 16, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 4 additions & 38 deletions exercises/hello-world/hello_world_test.py
Original file line number Diff line number Diff line change
@@ -1,48 +1,14 @@
# -*- coding: utf-8 -*-

from __future__ import unicode_literals
import unittest

import hello_world


class HelloWorldTests(unittest.TestCase):

def test_hello_without_name(self):
self.assertEqual(
'Hello, World!',
hello_world.hello()
)

def test_hello_with_sample_name(self):
self.assertEqual(
'Hello, Alice!',
hello_world.hello('Alice')
)
# test cases adapted from `x-common//canonical-data.json` @ version: 1.0.0

def test_hello_with_other_sample_name(self):
self.assertEqual(
'Hello, Bob!',
hello_world.hello('Bob')
)

def test_hello_with_umlaut_name(self):
self.assertEqual(
'Hello, Jürgen!',
hello_world.hello('Jürgen')
)

def test_hello_with_blank_name(self):
self.assertEqual(
'Hello, World!',
hello_world.hello('')
)
class HelloWorldTests(unittest.TestCase):

def test_hello_with_none_name(self):
self.assertEqual(
'Hello, World!',
hello_world.hello(None)
)
def test_hello(self):
self.assertEqual('Hello, World!', hello_world.hello())


if __name__ == '__main__':
Expand Down