Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(t3.rexx): upgrade unit test component code #135

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ajborla
Copy link
Member

@ajborla ajborla commented Jul 30, 2024

Includes the following commits:

2024-07-30 13:03:57 +1000 |ajborla| fix(t3.rexx): ensure quoting of literals in JSON output
2024-07-30 12:59:50 +1000 |ajborla| fix(t3.rexx): revise empty string test for test variables
2024-07-30 12:55:27 +1000 |ajborla| fix(t3.rexx): extract return value also from a CALL of code-under-test
2024-07-30 12:47:43 +1000 |ajborla| fix(t3.rexx): ensure raw newlines converted to '\n' in JSON output
2024-07-30 07:48:31 +1000 |ajborla| docs(t3.rexx): revise header to reflect latest changes

@ajborla ajborla added enhancement x:action/improve Improve existing functionality/content x:rep/large Large amount of reputation x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/large Large amount of work labels Jul 30, 2024
@ajborla ajborla self-assigned this Jul 30, 2024
@ajborla ajborla merged commit 6c4725d into exercism:main Jul 30, 2024
3 checks passed
@ajborla ajborla deleted the update_t3.rexx branch July 30, 2024 04:17
@kotp
Copy link
Member

kotp commented Jul 30, 2024

This has a listing of commits, but those are not "evergreen", but the SHA's would be, unless they are squashed, and then they would eventually go away due to git's garbage collection.

Just an FYI, since I searched for the described commits and I can not find them.

@ajborla
Copy link
Member Author

ajborla commented Jul 30, 2024 via email

@kotp
Copy link
Member

kotp commented Jul 30, 2024

Hi Victor, The listed commits are actually from another Github repository, ajborla/t-rexx, the repository from which the changed file, t3.rexx, originates. I included them for informational value only.

Ah, it was not clear, no link to the source, I thought this repository (being named rexx (under the namespace of exercism) was the reference.

In future I will merely list the tasks performed rather than copy-paste the commit messages. Many thanks for your advice, and for the time you took to look over the repository. All the best.

Sounds good, I do not think there is a pressing need to update the message here, unless you want to make it easier for future readers to get to your intended sources.

And thank you for your work, and your intended thoroughness in documenting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement x:action/improve Improve existing functionality/content x:rep/large Large amount of reputation x:size/large Large amount of work x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants