-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up topics
vs practices
in config.json
#1407
Comments
Hi! I created a PR for it. PD: clould you add #hacktoberfest tag? Thanks. |
@coriolinus, is this needs needed? |
Hi @ferminhg, sorry, I stepped down as maintainer of this repo some time ago. I assume that your PR is still useful but I will not be reviewing it. |
Hi @bobahop, do you know who can help me merge it? |
I'm sorry that the scope of this is beyond me at the moment. @petertseng may have some thoughts about this. |
Hi @petertseng , do you need help here? |
Wow I thought this was going to be some difficult thing that requires specific knowledge to review, but it's actually a fairly strictly rules-based change, with the instructions given in the issue description. It just says for any concept that exists in Line 1495 in d2a5ba3
topics to practices . Very rules-based, so reviewing pull requests just means checking that the rules are followed. CI validates that all concepts named in the practices array match a given concept so maintainers do not have to worry about that, just have to check that CI passes.
|
we also get warned if a concept is practiced more than 10 times, by https://github.com/exercism/configlet/blob/046e5c3bbb3a038bc6646604fcafc5d0747085a0/src/lint/track_config.nim#L340-L349. So we should probably avoid that. https://github.com/exercism/rust/blob/main/bin/clean_topics_vs_practices.py is a possibly that can help with this operation. |
Clean up topics vs practices in config.json #1407
Should this issue still be open? |
I think this should be kept open as documentation of what the purpose of the field |
Per the current docs, the track-level
config.json
's per-exercisetopics
key isn't used for anything. This has the advantage that the items there aren't constrained by cross-checks, but the disadvantage that we're not fully exposing to the website the information we have about each exercise.The general procedure we want to follow goes like this:
topics
topics
topractices
This process needs to be repeated periodically as we add concepts, so PRs addressing this issue should not close it.
The text was updated successfully, but these errors were encountered: