-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (concepts) Add new concept exercise phone-number-analysis
#1676
base: main
Are you sure you want to change the base?
Conversation
c39eaa8
to
e7eb454
Compare
// => (false, true, "1234") | ||
``` | ||
|
||
## 2. Detect if a phone number has a fake prefix code (555) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many people would consider that feature 2 would be a standalone test and that feature 1 would reference that test in constructing the feature 1 tuple. It seems that we are looking for feature 2 to return the second element of the feature 1 tuple (i.e. analyze().1) , rather than returning the value of the separate test, simply because the second part of feature 1 relies on feature 2.
Perhaps we should recognize that in the instructions and say (as we do in different exercises) that although you could simply return the value of the standalone test for fake 555 prefix, this exercise asks you to return the value based only on the phone number info produced in task 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand your concern on clarity, I don't understand how to make it more clear, the following along with the accompanying example should suffice
Implement the function
is_fake()
to detect whether the phone number is fake using the phone number info produced in task 1.
As I understand it, The purpose of second task is to learn how to take tuples as parameters and indexing tuples.
08c5c99
to
4f65cf9
Compare
This is inspired by the same in csharp track. Provides a gentle introduction to tuples.
The author of this PR has stopped responding in the discussions planning the work on the syllabus. But there's been work put into reviews already, so I'm keeping it open in case it can be salvaged in a future attempt to create a good syllabus. |
This is inspired by the same in csharp track. Provides a gentle introduction to tuples.