simplify generated gitignore files #2026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo has simplified its output a while ago, this is making us more consistent with that. Cargo doesn't add Cargo.lock anymore at all, neither for libraries nor for binaries. It still makes sense for us though, since our users shouldn't submit Cargo.lock to the test runner.
senekor
commented
Feb 17, 2025
| @@ -13,6 +13,7 @@ pub struct CanonicalData { | |||
| #[derive(Clone, Debug, Serialize, Deserialize)] | |||
| #[serde(deny_unknown_fields)] | |||
| #[serde(untagged)] | |||
| #[allow(clippy::large_enum_variant)] | |||
There was a problem hiding this comment.
unrelated piggyback :)
There was a problem hiding this comment.
clippy is too smart for its own good
ellnix
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Looks good to me!
For anyone looking at this in the future, relevant PRs on cargo:
rust-lang/cargo#12382
I hadn't really considered the git bisect argument but it's a good one. I don't think it applies to us though.
The crates.io guide page in the diff also seems to have moved:
https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo has simplified its output a while ago, this is making us more consistent with that. Cargo doesn't add Cargo.lock anymore at all, neither for libraries nor for binaries. It still makes sense for us though, since our users shouldn't submit Cargo.lock to the test runner.
I noticed this on the PR for list-ops, but thought it's better to update everything at once in a separate PR.