Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an object instead of a class for some exercises #242

Closed
5 tasks done
abo64 opened this issue Dec 14, 2016 · 2 comments
Closed
5 tasks done

Use an object instead of a class for some exercises #242

abo64 opened this issue Dec 14, 2016 · 2 comments
Labels
waiting for pr

Comments

@abo64
Copy link
Contributor

abo64 commented Dec 14, 2016 •
edited by ricemery
Loading

Some exercises require a class even though they don't have any internal state.
So they should be changed into an object.

  • allergies
  • atbash-cipher
  • crypto-square
  • queen-attack
  • raindrops
@abo64 abo64 changed the title queen-attack: Make Queens an object Use an object instead of a class for some exercises Dec 14, 2016
@ricemery
Copy link
Member

@abo64 , I can work through these or a subset of them if you haven't already started.

I do think that we should also address #137 for these exercises as long as we are modifying the exercises.

@abo64
Copy link
Contributor Author

abo64 commented Dec 15, 2016

@ricemery No, I haven't started. Please go ahead!

ricemery added a commit to ricemery/xscala that referenced this issue Dec 15, 2016
@ricemery
Allergies - use object instead of an instance - refs exercism#242. Ad…
147a25c 
…d Allergies.scala to src dir - refs exercism#137. Add topics to config.json - refs exercism#125
@ricemery ricemery mentioned this issue Dec 15, 2016
Merged
ricemery added a commit to ricemery/xscala that referenced this issue Dec 15, 2016
@ricemery
Atbash - use object instead of an instance - refs exercism#242. Add A…
39c35b3 
…tbash.scala - refs exercism#137. Add topics to config.json - refs exercism#125
@ricemery ricemery mentioned this issue Dec 15, 2016
Merged
ricemery added a commit to ricemery/xscala that referenced this issue Dec 15, 2016
@ricemery
CryptoSquare - use object instead of an instance - refs exercism#242.…
fe7f3b9 
… Add CryptoSquare.scala - refs exercism#137. Add topics to config.json - refs exercism#125
@ricemery ricemery mentioned this issue Dec 15, 2016
Merged
ricemery added a commit to ricemery/xscala that referenced this issue Dec 15, 2016
@ricemery
Queens - use object instead of an instance - refs exercism#242. Add Q…
aa7dfd3 
…ueens.scala - refs exercism#137. Add topics to config.json - refs exercism#125
@ricemery ricemery mentioned this issue Dec 15, 2016
Merged
ricemery added a commit to ricemery/xscala that referenced this issue Dec 15, 2016
@ricemery
Raindrops - use object instead of an instance - refs exercism#242. Ad…
81bed09 
…d Raindrops.scala - refs exercism#137. Add topics to config.json - refs exercism#125
@ricemery ricemery mentioned this issue Dec 15, 2016
Merged
ErikSchierboom added a commit that referenced this issue Dec 15, 2016
@ErikSchierboom
Merge pull request #243 from ricemery/allergies
e30e726 
Allergies - use object instead of an instance - refs #242. Add Allerg…
ErikSchierboom added a commit that referenced this issue Dec 15, 2016
@ErikSchierboom
Merge pull request #244 from ricemery/atbash-cipher
289d3a7 
Atbash - use object instead of an instance - refs #242. Add Atbash.sc…
ErikSchierboom added a commit that referenced this issue Dec 15, 2016
@ErikSchierboom
Merge pull request #245 from ricemery/crypto-square
831194c 
CryptoSquare - use object instead of an instance - refs #242. Add Cry…
abo64 added a commit that referenced this issue Dec 16, 2016
@abo64
Merge pull request #246 from ricemery/queens
4578ee0 
Queens - use object instead of an instance - refs #242. Add Queens.sc…
abo64 added a commit to abo64/xscala that referenced this issue Jan 5, 2017
@abo64
acronym: Change class to object (issue exercism#242)
b6179b5
@abo64 abo64 mentioned this issue Jan 5, 2017
Merged
abo64 added a commit to abo64/xscala that referenced this issue Jan 5, 2017
@abo64
roman-numerals: Change class to object (issue exercism#242)
5e4bfd2
@abo64 abo64 mentioned this issue Jan 5, 2017
Merged
ricemery added a commit that referenced this issue Jan 6, 2017
@ricemery
Merge pull request #264 from abo64/issue-242-acronym-as-object
bc7c6b9 
acronym: Change class to object (issue #242)
ricemery added a commit that referenced this issue Jan 6, 2017
@ricemery
Merge pull request #265 from abo64/issue-242-roman-numerals-as-object
f204a80 
roman-numerals: Change class to object (issue #242)
@abo64 abo64 mentioned this issue Jan 12, 2017
Merged
@abo64 abo64 mentioned this issue May 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for pr
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ricemery @abo64