Sync collatz-conjecture exercise #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keiravillekode
force-pushed
the
sync-exercises
branch
2 times, most recently
from
03688e5 to
4f8095b
Compare
keiravillekode
force-pushed
the
sync-exercises
branch
from
4f8095b to
2871da3
Compare
rainij
reviewed
Dec 23, 2023
There was a problem hiding this comment.
According to the tests.toml two tests are "reimplemented". I am not super familiar with how exercism works but I would expect that the actual tests also should change.
Maybe you can add some explanations to the description of the PR to make it clear what happens in this PR.
|
PR description updated. |
rainij
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike many tracks, the Standard ML implementation for the collatz-conjecture exercise does not use the error strings - it uses
NONEinstead.The error text in
problem-specificationsrecently changed. As thetest.smlfor this exercise does not contain error text, notest.smlchanges are needed at this time.