[DO NOT MERGE] added SimpleMinHeap #316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good so far! |
masters3d
commented
Jan 17, 2018
| if(rightChildIndex < array.count && ((rightChildIndex - 1)/2) == index ) { | ||
| let left = array[leftChildIndex] | ||
| let right = array[rightChildIndex] | ||
| let minChildIndex = left < right ? leftChildIndex : rightChildIndex |
There was a problem hiding this comment.
If left == right, which side should I choose? Does it matter? This impl chooses right side.
| } | ||
| } | ||
| // Convinience function that takes in a array converts it into a heap | ||
| mutating func heapify(_ input: [T]) { |
There was a problem hiding this comment.
Implement a better heapifi. Not sure how to test though. Ideas https://github.com/williamfiset/data-structures/blob/master/PriorityQueue/PQueue.java
|
Too Specific Seems like: exercism/problem-specifications#761 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waiting for exercism/problem-specifications#1128
Missing Readme.md