Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test to match exercise description. #522

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rhwood
Copy link
Contributor

@rhwood rhwood commented Nov 24, 2021

Assuming that I am interpreting the Bob exercise description correctly, this will fix #521.

Fixes #521

@ErikSchierboom
Copy link
Member

@rhwood This is basically the same PR as #507, but with the exemplar solution updated. Usually, we give precendence to earlier PRs when merging. @Ryan-Gross1993 were you planning on updating #507?

@rhwood
Copy link
Contributor Author

rhwood commented Nov 25, 2021

I submitted this and only afterwards discovered that #507 covered the same problem.

@ErikSchierboom
Copy link
Member

@rhwood I totally understand. It's an easy enough mistake :) I'll let Ryan reply, and then we'll see which PR to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test cases for Bob do not match exercise description.
2 participants