Fix build and prepare step #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarn install will install devdependencies - additionally it runs yarn prepublish (because that's how it works) - this in turn runs yarn test - this in turn runs yarn build (what we want) and jest (to validate) This means that the tests MUST be present when building the image. They are *not* copied over, so this is not an issues. Additionally, this creates a new production_node_modules folder with the right flags set, so that the final image node_modules is extremely small.
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn installwill installdevDependenciesyarn prepublish(because that's how it works)yarn testyarn build(what we want) andjest(to validate)This means that the tests MUST be present when building the image. They are not copied over, so this is not an issues.
Additionally, this creates a new
production_node_modulesfolder with the right flags set, so that the final imagenode_modulesis extremely small.