Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop count #1420

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Pop count #1420

merged 2 commits into from
Jan 31, 2024

Conversation

TheRealOwenRees
Copy link
Contributor

  • Pop Count practice exercise added

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 28, 2024
@iHiD iHiD reopened this Jan 28, 2024
@TheRealOwenRees
Copy link
Contributor Author

So if I am not mistaken, the failing test does not include any of the files from Pop-Count. I only formatted the files in this exercise. I hope that is correct,

@IsaacG
Copy link
Member

IsaacG commented Jan 28, 2024

It looks like you need to format the files with the prettier tool. There is a ./bin/format.sh which I think will do this for you.

Copy link
Contributor

The "Format code" action has started running.

@TheRealOwenRees
Copy link
Contributor Author

It looks like you need to format the files with the prettier tool. There is a ./bin/format.sh which I think will do this for you.

I believe that I did this, and the same error appeared in the checks as it does here.

Copy link
Contributor

The "Format code" action has started running.

@ErikSchierboom ErikSchierboom merged commit 047aaaf into exercism:main Jan 31, 2024
14 of 16 checks passed
@ErikSchierboom
Copy link
Member

Thanks!

@TheRealOwenRees TheRealOwenRees deleted the pop-count branch January 31, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants