Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exercise ✨: DnD Character #479

Merged
merged 7 commits into from
Sep 6, 2021
Merged

Conversation

joshiraez
Copy link
Contributor

Implements #344

@joshiraez joshiraez changed the title Implemented tests and proof dnd-character WIP: Implemented tests and proof dnd-character Apr 27, 2021
@joshiraez

This comment has been minimized.

@joshiraez joshiraez changed the title WIP: Implemented tests and proof dnd-character WIP: DnD Exercise **** Apr 27, 2021
@joshiraez joshiraez marked this pull request as draft April 27, 2021 03:47
@joshiraez joshiraez marked this pull request as ready for review April 27, 2021 23:57
@joshiraez joshiraez changed the title WIP: DnD Exercise **** WIP: DnD Exercise ✨ Apr 28, 2021
@joshiraez joshiraez changed the title WIP: DnD Exercise ✨ DnD Exercise ✨ Apr 28, 2021
@joshiraez joshiraez changed the title DnD Exercise ✨ New exercise ✨: DnD Character Apr 28, 2021
@SleeplessByte SleeplessByte self-assigned this Jul 5, 2021
@SleeplessByte SleeplessByte self-requested a review July 5, 2021 22:16
@exercism exercism deleted a comment from github-actions bot Sep 6, 2021
@exercism exercism deleted a comment from github-actions bot Sep 6, 2021
@exercism exercism deleted a comment from github-actions bot Sep 6, 2021
@SleeplessByte SleeplessByte merged commit 5a1ce7e into exercism:main Sep 6, 2021
@SleeplessByte
Copy link
Member

Thank you @joshiraez . What I've changed is the getters-functions which is very Java-like. Instead let's leave it up to the student to decide how to implement that. Both:

public readonly hitpoints: number;

...and:

public get hitpoints(): number {
  ...
}

now work.

@SleeplessByte SleeplessByte added x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts) labels Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/create Work on something from scratch x:knowledge/intermediate Quite a bit of Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:status/claimed Someone is working on this issue x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants