Upgrade to Rails 6 #725
Upgrade to Rails 6 #725
Conversation
|
@iHiD Ready for review. |
|
I've updated the ruby version for compatibility in Rails 6. We'll need to remember to update our chef scripts when we deploy this. |
|
Just working through the commits. On the commit "Rename classes for autoloading compliance", rather than renaming things, could you add the HTML, SQL, and anything else to |
|
Before deploying: Deployment checklist:
Setup:
|
|
@kntsoriano Can you check my last commit pls. Travis was failing without the mainfest change after a gem update. I removed the JS line and it worked (I presume that folder just isn't in Travis) and also checked Kaido and it's the same. So I think we're good but would appreciate a second pair of eyeballs. |
|
@iHiD Good catch. Rails 6 doesn't have that line in there now. |
We do not want to render JS before we render our HTML. Rendering JS blocks browsers from parsing any more of the DOM until the resource is loaded and parsed. We should probably consider using defer tags but for now I'd rather keep with the standards we have. See this article for more info: https://flaviocopes.com/javascript-async-defer/
Font awesome CDN is deprecated and are replaced by kits. This uses our own kit instead, which can be managed through the FA UI.
As part of this I've turned off support for FA-4 in the kit. I've tried to check every icon and look for renames where necessary. I might have missed some but I think I've done a good enough job.
This started as follows:
bundle updaterails app:updateand merged updates to the config filesThen @kntsoriano added commits explained in the messages.