This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[Python] Add new concept exercise : Comparisons #2949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
authors & editor
exchange_test / exchange
Line 2 from .exchange import * -> from exchange import *
add config.json add testcase & test file
added : currency-exchange/.meta/example.py added : currency-exchange/.docs/instructions.md
* added design.md added : currency-exchange/.meta/design.md
Added hint.md (#8)
* Delete .DS_Store * Add : hint.md (#9) Add : hint.md Solving Conflict
fix exchangable to exchangeable fix "Chandler want" to "Chandler wants" in instructions.md
* Fixed instructions.md Fixed grammatical errors in instructions.md based on BethanyG's review. Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com>
* Added new problem "Calculate unexchangeable value" Added modular arithmetic problem Calculate unexchangeable value * Added new problem "Calculate unexchangeable value" (example.py, exchange.py) Modified example.py, exchange.py * Modified Calculated unexchangeable value Modified `unexchangeable_value()` function's expected return type to be `int` * added new lines at the end of file * applied prettier on instructions.md Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com>
we changed the concept name, so needed to update file.
…fig.json we've decided to name the stub and test files for the concept and not the story.
…ign.md minor typo
removed arithmetic as a concept until we get the about.md file made.
…fig.json reverting file name change and deferring to different PR. This is currently breaking a CI test.
Add instructions.md
Add: instructions.md and problems
Add: config
* added example and instructions Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com>
* Fix the grammar in instructions.md * Fix the grammar in hints.md * Fix the grammar in introductions.md
|
@Limm-jk -- Was there an issue that made you close this? I know it has been sitting for a while (things have been crazy, and reviewing this slipped through the cracks), but it was on my list to review this week. My apologies that it has taken so long. Please let me know if you'd like to re-open. Thanks! |
|
This is great work, if you (authors: @Limm-jk @OMEGA-Y @Yabby1997 @Ticktakto @wnstj2007 ) are willing to, we can merge that pr to master |
This was referenced Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, This is exercise that I promised to work on. We've created a new exercise about Concepts 'comparisons'. #2039
This exercise contains
=, <, >, and in.I worked with OMEGA-Y / Yabby1997 / Ticktakto / wnstj2007
Any guidance is appreciated!