go/raindrops: missing comments for disapprove #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iHiD
requested review from
bitfield,
SleeplessByte,
kytrinyx and
ErikSchierboom
kytrinyx
reviewed
Aug 16, 2019
ErikSchierboom
previously approved these changes
Aug 17, 2019
SleeplessByte
previously approved these changes
Aug 18, 2019
Co-Authored-By: Derk-Jan Karrenbeld <derk-jan+github@karrenbeld.info>
tehsphinx
dismissed stale reviews from SleeplessByte and ErikSchierboom
via
60c1611
|
@iHiD: Can we get this merged? Even if we might rephrase things again? Currently mentors are missing these comments and then wonder why it says not to approve. |
|
Merging. We can move forward on new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.