Add rotational-cipher exercise #152
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
| return String.fromCodePoint(codePoint) | ||
| } | ||
| return text.codePoints.map(rotateCodePoint).join() | ||
| } |
There was a problem hiding this comment.
| return String.fromCodePoint(codePoint) | |
| } | |
| return text.codePoints.map(rotateCodePoint).join() | |
| } | |
| String.fromCodePoint(codePoint) | |
| } | |
| text.codePoints.map(rotateCodePoint).join() | |
| } |
Like in Ruby return is not necessary in most cases.
There was a problem hiding this comment.
I have now made rotate a single-line function, with no return keyword.
If we remove the return before String.fromCodePoint(codePoint) I observe results like nullnullnullnullnull
There was a problem hiding this comment.
This is discussed in https://wren.io/syntax.html#blocks -- as soon as there's a newline after the opening {, you need to explicitly return
No description provided.