-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the two-fer exercise #759
Conversation
exercises/two-fer/description.md
Outdated
also important not to over-engineer a solution. | ||
|
||
It's important to remember that the goal is to make code as expressive and | ||
readable as we can. However, solutions to the hello-world exercise will not be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hello-world
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming this exercise will be reviewed by other users unlike hello-world
which was being reviewed only by rikki. So I guess I should remove this sentence altogether.
a4e5615
to
ffdb41e
Compare
by always expecting "Hello, World!" Change in x-common: [here](exercism/problem-specifications#544) Upcoming new exercise to kinda replace `hello-world`: [here](exercism/problem-specifications#759) Since this `hello-world` is just meant to be a sanity check for everything working, I also went ahead and removed the use of class for the sake of simplicity. We can introduce classes with the next `two-fer` exercise.
by always expecting "Hello, World!" Change in x-common: [here](exercism/problem-specifications#544) Upcoming new exercise to kinda replace `hello-world`: [here](exercism/problem-specifications#759) Since this `hello-world` is just meant to be a sanity check for everything working, I also went ahead and removed the use of class for the sake of simplicity. We can introduce classes with the next `two-fer` exercise.
exercises/two-fer/description.md
Outdated
@@ -0,0 +1,42 @@ | |||
`Two-fer` or `2-fer` is short for two for one. One for you and one for me. | |||
|
|||
This exercise expects you to create a sentence of the form: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this sound repetitive when the sentence from the blurb is prepended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We really should stop doing that. (prepending blurb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, this will be repetitive, I will remove this.
I would remove all the TDD stuff from the exercise description. We have different |
They were there in |
This is meant to be right after hello-world introducing users to basic programming constructs as well as TDD which will be used in all later exercises. Discussion regarding this is [here](exercism#548). Closes exercism#757.
ffdb41e
to
2fea3ac
Compare
Can we merge this? |
Seems this has been sitting as approved for long enough. If any other issues come up a new issue/PR can be opened to address it. I'm going to merge this. Thanks @tejasbubane. |
meetup: tests are now generated
This is meant to be right after hello-world introducing users to basic
programming constructs as well as TDD which will be used in all later
exercises.
Discussion regarding this is here.
Closes #757.