Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the two-fer exercise #759

Merged
merged 1 commit into from
May 31, 2017

Conversation

tejasbubane
Copy link
Member

This is meant to be right after hello-world introducing users to basic
programming constructs as well as TDD which will be used in all later
exercises.

Discussion regarding this is here.

Closes #757.

also important not to over-engineer a solution.

It's important to remember that the goal is to make code as expressive and
readable as we can. However, solutions to the hello-world exercise will not be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello-world

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming this exercise will be reviewed by other users unlike hello-world which was being reviewed only by rikki. So I guess I should remove this sentence altogether.

tejasbubane added a commit to tejasbubane/xjavascript that referenced this pull request Apr 18, 2017
by always expecting "Hello, World!"

Change in x-common:
[here](exercism/problem-specifications#544)

Upcoming new exercise to kinda replace `hello-world`:
[here](exercism/problem-specifications#759)

Since this `hello-world` is just meant to be a sanity check for
everything working, I also went ahead and removed the use of class
for the sake of simplicity.
We can introduce classes with the next `two-fer` exercise.
matthewmorgan pushed a commit to exercism/javascript that referenced this pull request Apr 18, 2017
by always expecting "Hello, World!"

Change in x-common:
[here](exercism/problem-specifications#544)

Upcoming new exercise to kinda replace `hello-world`:
[here](exercism/problem-specifications#759)

Since this `hello-world` is just meant to be a sanity check for
everything working, I also went ahead and removed the use of class
for the sake of simplicity.
We can introduce classes with the next `two-fer` exercise.
@@ -0,0 +1,42 @@
`Two-fer` or `2-fer` is short for two for one. One for you and one for me.

This exercise expects you to create a sentence of the form:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this sound repetitive when the sentence from the blurb is prepended?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really should stop doing that. (prepending blurb)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this will be repetitive, I will remove this.

@behrtam
Copy link
Contributor

behrtam commented Apr 23, 2017

I would remove all the TDD stuff from the exercise description. We have different docs for those kind of stuff.

@tejasbubane
Copy link
Member Author

I would remove all the TDD stuff from the exercise description. We have different docs for those kind of stuff.

They were there in hello-world hence I put them here. I don't mind removing them if we have docs, but then we should atleast put a link to the docs.

This is meant to be right after hello-world introducing users to basic
programming constructs as well as TDD which will be used in all later
exercises.

Discussion regarding this is [here](exercism#548).

Closes exercism#757.
@tejasbubane
Copy link
Member Author

Can we merge this?

@rpottsoh
Copy link
Member

rpottsoh commented May 31, 2017

Seems this has been sitting as approved for long enough. If any other issues come up a new issue/PR can be opened to address it. I'm going to merge this.

Thanks @tejasbubane.

@rpottsoh rpottsoh merged commit a3418f4 into exercism:master May 31, 2017
@tejasbubane tejasbubane deleted the implement-two-fer branch May 31, 2017 10:33
emcoding pushed a commit that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants