-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exercises(raindrops): implement #155
Conversation
a6e0bb8
to
516a2f7
Compare
516a2f7
to
fcec73c
Compare
Is the solution correct? Or testing? I think either we
|
Use the variable name that we use in the tests, and other exercises.
Make it more reasonable to add a test for a large number later, and make the required buffer size more obvious (the maximum value of a usize on a 64-bit platform has 20 digits).
cf8998b
to
7c99604
Compare
Not currently consequential.
@rofrol Hey. Thanks for the comment, and sorry for the slow reply. The example solution here isn't returning a pointer to stack-allocated memory, if that's what you mean. But it's not critically important that the example solution in this repo is the most idiomatic one, partly because the example solution isn't user-facing. The important thing is that the example solution passes the tests, and that the tests are such that it's possible to write a reasonably idiomatic solution (or ideally, a range of reasonable solutions, so that there's scope for discussing the tradeoffs of various approaches). Please yell at me if you think the tests don't allow that. And let's go without an allocator for this exercise. We'll have enough exercises that use an allocator, and in this one, we always know the maximum memory required at the call site. |
To-do:
practices
/prerequisites