Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data retrieval testing #16

Closed
maxUser opened this issue Feb 23, 2020 · 3 comments · Fixed by #43
Closed

Data retrieval testing #16

maxUser opened this issue Feb 23, 2020 · 3 comments · Fixed by #43
Assignees
Labels
testing We need to add testing
Milestone

Comments

@maxUser
Copy link
Contributor

maxUser commented Feb 23, 2020

We need to add test cases for data retrieval and validation.

@maxUser maxUser added the enhancement New feature or request label Feb 23, 2020
@maxUser maxUser added this to the Getting Started milestone Feb 23, 2020
@nikola-rados nikola-rados added testing We need to add testing and removed enhancement New feature or request labels Feb 27, 2020
@nikola-rados nikola-rados removed their assignment Jun 5, 2020
@nikola-rados nikola-rados modified the milestones: Alligator, Bison Jun 5, 2020
@maxUser maxUser removed their assignment Jun 7, 2020
@maxUser maxUser removed their assignment Jun 7, 2020
@maxUser
Copy link
Contributor Author

maxUser commented Jun 19, 2020

@nikola-rados should we just delete this? I think the real testing we need is to make sure the commands run. While working on the !matchday command, the command would break after making changes mostly because of syntax or logic errors. Can we write a test for each command to make sure they still run?

@nikola-rados
Copy link
Contributor

I think the idea behind this issue is that it would check the commands as well as some of the util functions we’ve made. I feel like it’s still valid.

@maxUser
Copy link
Contributor Author

maxUser commented Jun 19, 2020

Okay sounds good. We should talk about this in the near future then. I have some questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing We need to add testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants