Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing #43

Merged
merged 15 commits into from
Jun 28, 2020
Merged

Add testing #43

merged 15 commits into from
Jun 28, 2020

Conversation

nikola-rados
Copy link
Contributor

Description

  • Add online tests
  • Add coverage to pytest

Resolves #16

Special Notes

This was not fun to do at all. It really exposes how poorly we've done a bunch of things in here, which could be a good thing I guess. But it makes the tests I've added SUPER unreliable. Hitting an online resource for our testing is not great, and the outputs change week-to-week. I believe a lot of these tests will be obsolete soon as we migrate the data downloading away from this repo. So they are fine for now as just a bare minimum.

Suggested Version Bump

  • Major
  • Minor
  • Patch

Checklist:

  • I have run black .
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added logging

@nikola-rados nikola-rados added the testing We need to add testing label Jun 27, 2020
@nikola-rados nikola-rados added this to the Bison milestone Jun 27, 2020
@nikola-rados nikola-rados requested a review from maxUser June 27, 2020 17:47
@nikola-rados nikola-rados self-assigned this Jun 27, 2020
@maxUser maxUser merged commit 5f33748 into master Jun 28, 2020
@maxUser maxUser deleted the i16-testing branch June 28, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing We need to add testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data retrieval testing
2 participants