-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded messages #13
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-rados
force-pushed
the
i3-embedded-messages
branch
from
February 20, 2020 07:18
4193b89
to
092aa21
Compare
maxUser
requested changes
Feb 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests all passed.
maxUser
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great compromise. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bot.py
script to handle a passedtoken
or an envtoken
getStats
command that returns dummy datautils/
folder for non-command itemsmessages.py
to handle a general embedded message case (some items here are still hardcoded such as thecolour
andthumbnail
)dummy_data.py
which will contains a method to create data for the command calltest_requirements
along withpy.test
tests/
with simple tests for utility functionsResolves #3
Special Notes
I'd recommend trying out this command live in discord to ensure there are no issues. Also if you have any suggestions for what cases to test that would be very helpful.
Last note is that I added a github action in a recent PR #12. Going forward we'll want to ensure the latest commit passed the action before approving (this is denoted by the green checkmark next to the commit, click on it for more details).
Expected Version Bump
Checklist:
black .