Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded messages #13

Merged
merged 15 commits into from
Feb 22, 2020
Merged

Embedded messages #13

merged 15 commits into from
Feb 22, 2020

Conversation

nikola-rados
Copy link
Contributor

@nikola-rados nikola-rados commented Feb 20, 2020

Description

  • Reworks the main bot.py script to handle a passed token or an env token
  • Adds a getStats command that returns dummy data
  • Adds a utils/ folder for non-command items
  • Adds messages.py to handle a general embedded message case (some items here are still hardcoded such as the colour and thumbnail)
  • Adds dummy_data.py which will contains a method to create data for the command call
  • Adds test_requirements along with py.test
  • Adds tests/ with simple tests for utility functions

image

Resolves #3

Special Notes

I'd recommend trying out this command live in discord to ensure there are no issues. Also if you have any suggestions for what cases to test that would be very helpful.

Last note is that I added a github action in a recent PR #12. Going forward we'll want to ensure the latest commit passed the action before approving (this is denoted by the green checkmark next to the commit, click on it for more details).

Expected Version Bump

  • Major
  • Minor
  • Patch
  • None

Checklist:

  • I have run black .
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@nikola-rados nikola-rados added the enhancement New feature or request label Feb 20, 2020
@nikola-rados nikola-rados added this to the Getting Started milestone Feb 20, 2020
@nikola-rados nikola-rados requested a review from maxUser February 20, 2020 06:58
@nikola-rados nikola-rados changed the title I3 embedded messages Embedded messages Feb 21, 2020
Copy link
Contributor

@maxUser maxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all passed.

bot.py Show resolved Hide resolved
cogs/stats.py Outdated Show resolved Hide resolved
Copy link
Contributor

@maxUser maxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great compromise. Thanks.

@nikola-rados nikola-rados merged commit 6ade234 into master Feb 22, 2020
@nikola-rados nikola-rados deleted the i3-embedded-messages branch February 22, 2020 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedded Messages
2 participants