Matchday command #22
Merged
Matchday command #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-rados
approved these changes
Mar 21, 2020
There was a problem hiding this comment.
This looks good @maxUser! We should probably remove some files but otherwise the code looks great!
.gitignore
Outdated
| @@ -1,4 +1,5 @@ | |||
| venv | |||
| __pycache__ | |||
| cogs/__pycache__ | |||
| the_mines/.DS_Store | |||
| the_mines/data/.DS_Store | |||
There was a problem hiding this comment.
This should not be getting added. Is it part of the .gitignore?
Comment on lines
+32
to
+33
| name=value[0][0] + "-" + value[1][0], | ||
| value=value[0][1] + "-" + value[1][1], |
There was a problem hiding this comment.
There may be a cleaner way of joining the items in the tuple rather than indexing. Indexing can be difficult to understand if you don't know the exact structure of the tuple being passed in. Maybe we could look into using an iterator with .join()?
There was a problem hiding this comment.
Great idea. Can you help me implement this?
|
@maxUser LGTM, merge away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #19
Special Notes
Expected Version Bump
Checklist:
black .