Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ArgParse with Click #24

Merged
merged 4 commits into from
May 31, 2020
Merged

Replace ArgParse with Click #24

merged 4 commits into from
May 31, 2020

Conversation

nikola-rados
Copy link
Contributor

Description

  • Use modern CLI tooling click

Resolves #7

Special Notes

This will run exactly as it has before but gives us a bit more flexibility going forward.

Expected Version Bump

  • Major
  • Minor
  • Patch
  • None

Checklist:

  • I have run black .
  • I have made corresponding changes to the documentation (n/a)
  • I have added tests that prove my fix is effective or that my feature works (n/a)

@nikola-rados nikola-rados added the refactor An overhaul label May 29, 2020
@nikola-rados nikola-rados added this to the Backlog milestone May 29, 2020
@nikola-rados nikola-rados requested a review from maxUser May 29, 2020 02:23
maxUser
maxUser requested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@maxUser maxUser left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the argparse import in bot.py?

@maxUser maxUser merged commit d0e4825 into master May 31, 2020
@nikola-rados nikola-rados deleted the i7-click branch June 7, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxUser maxUser maxUser requested changes

Assignees
No one assigned
Labels
refactor An overhaul
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Replace ArgParse with Click
2 participants
@nikola-rados @maxUser