Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i28 matchday defaults #36

Merged
merged 15 commits into from
Jun 18, 2020
Merged

i28 matchday defaults #36

merged 15 commits into from
Jun 18, 2020

Conversation

maxUser
Copy link
Contributor

@maxUser maxUser commented Jun 15, 2020

Description

  • Changed name of getMatchday command (now: !matchday)
  • Running !matchday without arguments returns results from most recent matchday
  • Refactored software layout to match branch #i26-blurb

Resolves #i28-matchday-defaults

Special Notes

  • Review the code differences between this branch and i26-blurb to make sure they are as compatible as possible

Suggested Version Bump

  • Major
  • Minor
  • Patch

Checklist:

  • I have run black .
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added logging

@maxUser maxUser added enhancement New feature or request refactor An overhaul labels Jun 15, 2020
@maxUser maxUser added this to the Bison milestone Jun 15, 2020
@maxUser maxUser linked an issue Jun 15, 2020 that may be closed by this pull request
Default outputs for getMatchday #28
Closed
@maxUser maxUser requested a review from nikola-rados June 15, 2020 04:53
nikola-rados
nikola-rados requested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@nikola-rados nikola-rados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work cleaning this up @maxUser. Its looks like a million bucks compared to what it was before. I think with a little bit of work it will be ready to go!

utils/messages.py Outdated Show resolved Hide resolved
utils/misc.py Outdated Show resolved Hide resolved
the_mines/process/fussballdaten/process_matchday.py Outdated Show resolved Hide resolved
the_mines/download/get_html.py Outdated Show resolved Hide resolved
cogs/stats_commands.py Outdated Show resolved Hide resolved
the_mines/download/get_html.py Outdated Show resolved Hide resolved
utils/messages.py Show resolved Hide resolved
nikola-rados
nikola-rados approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@nikola-rados nikola-rados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great work @maxUser! I'm stoked to pull this into master. If you go for the merge be sure to add "#major" to the message to bump us to 1.0.0 🥳

@maxUser maxUser merged commit a008cc3 into master Jun 18, 2020
@maxUser maxUser deleted the i28-matchday-defaults branch June 18, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikola-rados nikola-rados nikola-rados approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor An overhaul
Projects
None yet
Milestone
Bison
Development

Successfully merging this pull request may close these issues.

Default outputs for getMatchday
2 participants
@maxUser @nikola-rados