-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I27 blurb #37
I27 blurb #37
Conversation
I'm having an issue with using teams with umlauts in their names as arguments. I tried Koln, Dusseldorf, Köln, Düsseldorf, Duesseldorf, Koeln. None were recognized by the bot. |
@maxUser good find, it is in fact an issue. At a glance it looks like its from extracting the team from the league table. Working on it. |
A fix has been pushed in the form of a de-accenting method. You can now use either accented or non-accented inputs. I think our current strategy isn't robust against team names with multiple accented letters. I'm not sure how comment that is in german but it may be something to consider for the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this. I think we can do a lot more with it as well. Code looks really nice too - helped me to improve my own :) the only thing that I scratch my head at is why it takes like 5 seconds after typing the command for the blurb to pop up.
Description
blurb
commandutils
fileembedder
Resolves #27
Special Notes
I ended up only getting the most recent result rather than the most recent 2 results. I felt it was a bit unnecessary to go further back.
Suggested Version Bump
Checklist:
black .