Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I27 blurb #37

Merged
merged 30 commits into from
Jun 21, 2020
Merged

I27 blurb #37

merged 30 commits into from
Jun 21, 2020

Conversation

nikola-rados
Copy link
Contributor

Description

  • add blurb command
  • restructure some of the files/directories
  • generalize several functions
  • add utils file
  • create embedder
  • other small things I'm forgetting

screenshpt

Resolves #27

Special Notes

I ended up only getting the most recent result rather than the most recent 2 results. I felt it was a bit unnecessary to go further back.

Suggested Version Bump

  • Major
  • Minor
  • Patch

Checklist:

  • I have run black .
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have added logging

@nikola-rados nikola-rados added the enhancement New feature or request label Jun 17, 2020
@nikola-rados nikola-rados added this to the Bison milestone Jun 17, 2020
@nikola-rados nikola-rados requested a review from maxUser June 17, 2020 01:45
@maxUser
Copy link
Contributor

maxUser commented Jun 17, 2020

I'm having an issue with using teams with umlauts in their names as arguments. I tried Koln, Dusseldorf, Köln, Düsseldorf, Duesseldorf, Koeln. None were recognized by the bot.

@nikola-rados
Copy link
Contributor Author

@maxUser good find, it is in fact an issue. At a glance it looks like its from extracting the team from the league table. Working on it.

@nikola-rados
Copy link
Contributor Author

A fix has been pushed in the form of a de-accenting method. You can now use either accented or non-accented inputs. I think our current strategy isn't robust against team names with multiple accented letters. I'm not sure how comment that is in german but it may be something to consider for the future.

screenshot

Copy link
Contributor

@maxUser maxUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. I think we can do a lot more with it as well. Code looks really nice too - helped me to improve my own :) the only thing that I scratch my head at is why it takes like 5 seconds after typing the command for the blurb to pop up.

@nikola-rados nikola-rados merged commit 71b9de0 into master Jun 21, 2020
@nikola-rados nikola-rados deleted the i27-blurb branch June 21, 2020 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blurb Command
2 participants