Skip to content

HTMLVideoElement unlock #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4,510 commits into from
Closed

HTMLVideoElement unlock #596

wants to merge 4,510 commits into from

Conversation

avaer
Copy link
Member

@avaer avaer commented Nov 11, 2018

HTMLVideoElement was commented before due to lack of testing.

This PR fixes several bugs with the implementation and re-enables <video> support.

Avaer Kazmer added 30 commits October 22, 2018 22:09
Bugfix realitytabs.html example layers initialization
8b1c5df
Move to using fakeDisplay layers instead of manual composeLayers call…
2828f89 
… in realitytabs.html example
Go back to manual composeLayers call
59c42a8
EGL dead CreateRenderTarget code cleanup
2fbc2ae
Patch magicleap CreateRenderTarget call to windowsystembase
b9039cf
Bugfix windowsystem comopose framgment shader
596596f
Add missing windowsystembase CreateRenderTarget method
c6deb62
Bugfix windowsystem typo
9e7e477
Commenting cleanup in windowsystem
88fa457
Bugfix windowsystem typos
e4c4410
Bugfix XR window name typo
89ea83a
Hook in fakje vr display layers handling
d5f64ec
Small index.js spacing cleanup
3fe6b07
Revert "Remove dead browser composeLayers method exposure"
aa154a3 
This reverts commit fa51c91.
Clean up exposed composeLayers method arguments
fd42a87
Add initial windowsystem texSize parameter
026c8c3
Only use windowsystem glTexStorage2DMultisample in the LUMIN case
4342f71
Bugfix reality tabs texSize handling
73ad266
Small windowsystem cleanup
528ae9e
Add windowsystem ComposeLayers invalid layer object throw
f17fa78
Small index.js texture naming cleanup
bce2c8c
Expose createRenderTarget in core.js
ce5b83d
Fake display API cleanup in realitytabs.html example
5c171fb
Bugfix windowsystem canvas layer spec tex setting
0b0eaaa
Small webgl.cc handle scope cleanup
fd98377
Bugfix index.js canvas framebuffer latching
8049ce6
Bugfix composeLayers color texture latching
ea9c0f3
Add webgl getFramebuffer call
bc16c3f
Add webgl bindFramebufferRaw method
7c36be1
Realitytabs.html example cleanup
ec2555f
@avaer
Copy link
Member Author

avaer commented Nov 11, 2018 •
edited
Loading

We should also:

  • Thread the decode
  • Draw the video textures to GL -- unlike a 2D browser, if someone is requesting a video they are probably going to be injecting it into the scene
  • Enable accelerated decoding

@avaer
Copy link
Member Author

avaer commented Nov 13, 2018

This should be decoding in parallel on a thread now.

@avaer
Copy link
Member Author

avaer commented Nov 15, 2018

Adding hardware acceleration turned out to be straightforward (2a1f938#diff-50c6fafb71eb1398f06c6da1ba93730dR19).

@avaer avaer closed this Aug 5, 2019
@avaer avaer mentioned this pull request Aug 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avaer @machenmusik @sidequestlegend