Merge pull request #113 from exonet/tsi/utest

Add unit test for getShortName
exonet · Jun 20, 2022 · bb65efc · bb65efc
2 parents 3342521 + c128397
commit bb65efc
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 8 deletions.
diff --git a/src/Resources/ResourceRecord.php b/src/Resources/ResourceRecord.php
@@ -243,22 +243,22 @@ public function getName(): string
  * Get the name of the resource record without the domain name.
  * "@" when empty.
  *
- * @throws PowerdnsException
+ * @throws PowerdnsException If it is not possible to shorten the name.
  *
  * @return string The short name
  */
  public function getShortName(): string
  {
- if ($this->zone !== null) {
- $name = substr($this->name, 0, -(strlen($this->zone->getCanonicalName()) + 1));
-
- if (strlen($name) == 0) {
- $name = '@';
- }
- } else {
+ if ($this->zone === null) {
  throw new PowerdnsException('No zone set for this ResourceRecord. Unable to shorten name');
  }
 
+ $name = substr($this->name, 0, -(strlen($this->zone->getCanonicalName()) + 1));
+
+ if ($name === '' || $name === false) {
+ return '@';
+ }
+
  return $name;
  }
 

diff --git a/tests/Resources/ResourceRecordTest.php b/tests/Resources/ResourceRecordTest.php
@@ -108,4 +108,24 @@ public function testSetTypeWithInvalidTypeThrowsException()
 
  $resourceRecord->setType('test');
  }
+
+ public function testGetShortName(): void
+ {
+ $zone = Mockery::mock(Zone::class);
+ $zone->shouldReceive('getCanonicalName')->once()->andReturn('test-zone.dev');
+
+ $resourceRecord = new ResourceRecord();
+ $resourceRecord->setName('unit.test-zone.dev');
+
+ $resourceRecord->setZone($zone);
+ $this->assertSame('unit.test-zone.dev', $resourceRecord->getName());
+ $this->assertSame('unit', $resourceRecord->getShortName());
+
+ $resourceRecord->setName('test-zone.dev');
+ $this->assertSame('test-zone.dev', $resourceRecord->getName());
+ $this->assertSame('@', $resourceRecord->getShortName());
+
+ $this->expectExceptionMessage('No zone set for this ResourceRecord. Unable to shorten name');
+ (new ResourceRecord())->getShortName();
+ }
 }