Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change parameter $omitDnssecAndEditedSerialFields to $includeDnssecAndEditedSerialFields #139

Merged
merged 1 commit into from
May 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Powerdns.php
Original file line number Diff line number Diff line change
Expand Up @@ -208,19 +208,19 @@ public function deleteZone(string $canonicalDomain): bool
/**
* Retrieve all zones.
*
* @param bool $omitDnssecAndEditedSerialFields When set to true dnssec and edited_serial are omitted
* @param bool $includeDnssecAndEditedSerialFields If 'true' then dnssec and edited_serial are included.
*
* @return Zone[] Array containing the zones
*
* @see https://doc.powerdns.com/authoritative/http-api/zone.html#get--servers-server_id-zones
*/
public function listZones(bool $omitDnssecAndEditedSerialFields = false): array
public function listZones(bool $includeDnssecAndEditedSerialFields = false): array
{
return array_map(
function (array $args) {
return new Zone($this->connector, $args['id']);
},
$this->connector->get('zones?dnssec='.($omitDnssecAndEditedSerialFields ? 'true' : 'false'))
$this->connector->get('zones?dnssec='.($includeDnssecAndEditedSerialFields ? 'true' : 'false'))
);
}

Expand Down
4 changes: 2 additions & 2 deletions src/PowerdnsInterface.php
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@ public function deleteZone(string $canonicalDomain): bool;
/**
* Retrieve all zones.
*
* @param bool $omitDnssecAndEditedSerialFields When set to true dnssec and edited_serial are omitted
* @param bool $includeDnssecAndEditedSerialFields When set to true dnssec and edited_serial are omitted
*
* @return Zone[] Array containing the zones
*
* @see https://doc.powerdns.com/authoritative/http-api/zone.html#get--servers-server_id-zones
*/
public function listZones(bool $omitDnssecAndEditedSerialFields = false): array;
public function listZones(bool $includeDnssecAndEditedSerialFields = false): array;

/**
* Get a cryptokey instance to work with.
Expand Down