Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsec3): fixes unset nsec3param not working #152

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

SurajDadral
Copy link
Contributor

Description

$powerdns->zone($domain)->unsetNsec3param()

This wasn't working because {"nsec3param": null} was passed in API.
Now, modified to pass {"nsec3param": ""} in API to unset nsec3param.

How has this been tested?

php: 8.2
powerdns version: 4.9.1-1pdns.buster

All phpunit test cases passed: ./vendor/bin/phpunit

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Tested with:
php: 8.2
powerdns version: 4.9.1-1pdns.buster
@trizz trizz added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Jun 21, 2024
@trizz
Copy link
Member

trizz commented Jun 21, 2024

Hi @SurajDadral

Thanks for the fix! I'll merge and release it.

@trizz trizz merged commit 6194a9d into exonet:master Jun 21, 2024
1 of 3 checks passed
@SurajDadral SurajDadral deleted the nsec3 branch June 21, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Inconsistencies or issues which will cause a problem for users or implementors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants