Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make nameservers auto canoncial #153

Merged

Conversation

bennetgallein
Copy link
Contributor

Description

the #setNameservers method will accept any input, while powerdns only accept canonical nameservers (ending in .). With the PR, the dot will be automatically appended if it's missing.

Motivation and context

Automatically settings this resolve an issue i'm having with customer not setting the appending dot.

How has this been tested?

tests were fitted

Checklist:

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • My pull request contains a title that can be used as a release note.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

@bennetgallein
Copy link
Contributor Author

Hey @trizz this might be somewhat controversial on who should do this validation, but since the lib already appends the domain name to records, I think a bit more help for inexperienced administrators is not wrong here. Lmk if there's anything I should change or if you know of any other places that might have this issue.

@trizz trizz self-assigned this Sep 2, 2024
@trizz trizz added the enhancement Enhancement of the code, not introducing new features. label Sep 9, 2024
@trizz
Copy link
Member

trizz commented Sep 9, 2024

Hi @bennetgallein ,

Thanks for your PR. I agree that this change makes things a bit more user-friendly and aligns better with the domain name records. I also don’t foresee any breaking changes or backward incompatibility resulting from this change.

@trizz trizz merged commit 59dc5d6 into exonet:master Sep 9, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants