Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to return statistics endpoint data #45

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

akondas
Copy link
Contributor

@akondas akondas commented Oct 29, 2020

Description

Allow to fetch PowerDNS internal statistics:
https://doc.powerdns.com/authoritative/http-api/statistics.html

Motivation and context

I would like to be able to extract statistics with this library.

How has this been tested?

Tested with real PowerDNS instance.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

@robbinjanssen
Copy link
Member

Hi @akondas, thanks for your PR!

Looking good, i'll discuss this within our team tomorrow. We'll also look into why travis is failing and how we can fix this (since that has nothing to do with your PR).

@styxit styxit mentioned this pull request Oct 30, 2020
9 tasks
@trizz trizz merged commit 66bc4d9 into exonet:master Oct 30, 2020
@styxit styxit self-assigned this Oct 30, 2020
@styxit
Copy link
Member

styxit commented Oct 30, 2020

Thanks for contributing! We decided to add support for the available parameter on the statistics endpoint and exclude the ring statistics by default.

The new statistics() method has been released in version v2.5.0

@akondas akondas deleted the statistics branch October 30, 2020 14:01
@akondas
Copy link
Contributor Author

akondas commented Oct 30, 2020

Thanks for such quick release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants