Describe RFC process #1

oudod · 2017-07-24T14:04:06Z

No description provided.

alexauroradev

LGTM after adding necessary info in TODOs:

First TODO with examples: you can use the ones that we've discussed today.

Services isolation. A major improvement which is aimed at separating storage and execution environments of services.
Transaction finality. Adding additional mechanisms for transaction finalization without inclusion to a blockchain.
Code parallelization. Make Exonum able to run on several cores simultaneously.

Second todo: probably need something similar for "motion for final comment period" as in Rust and also info about when the number is attached.

alexauroradev

LGTM

slowli

Mostly good, but I think RFC licensing needs to be reworked - it may be too restrictive in certain scenarios.

slowli · 2017-07-27T16:20:41Z

README.md

+[Exonum RFCs]: #exonum-rfcs
+
+Exonum RFC process is partially derived from [the Rust RFC process](https://github.com/rust-lang/rfcs/blob/master/README.md)


I couldn't find out the license for the Rust RFCs. Are you sure we can use it?

According to this comment rust-lang/rfcs#1259 (comment), we are not first.

More info on rust-lang/rfcs licensing:
https://github.com/rust-lang/rfcs/blob/master/text/2044-license-rfcs.md
rust-lang/rfcs#2075

slowli · 2017-07-27T16:22:31Z

README.md

+following.
+
+- API changes.


Inconsistent indentation with other lists. Also: what does "API changes" entail? Changes in the public interface of the exonum crate?

slowli · 2017-07-27T16:37:48Z

README.md

+request.
+
+Maintainers of related repositories makes final decisions about RFCs after the


Nitpick: s/makes/make/

slowli · 2017-07-27T16:38:24Z

README.md

+
+[RFC issue tracker]: https://github.com/exonum/rfcs/issues
+[RFC repository]:  https://github.com/exonum/rfcs


Nitpick: unnecessary spacing.

slowli · 2017-07-27T16:40:56Z

README.md

+
+The Exonum RFCs are licensed under the Creative Commons Non-Commercial
+Share-Alike International License (version 4.0).


Are you sure this is a good choice? Compare with BIP licensing.

Maria-Nosyk · 2017-08-02T11:10:52Z

README.md

+
+The "RFC" (request for comments) process is intended to provide a consistent
+and controlled path for new features to enter the Exonum, so that all


The "RFC" (request for comments) process

(Request for Comments)

new features to enter the Exonum

delete "the"

Maria-Nosyk · 2017-08-02T11:24:07Z

README.md

+  - Adding new features.
+  - Removing existing features.
+  - Changing feature behavior.


Changing features behavior. - sounds better due to parallel contructions in the list

Maria-Nosyk · 2017-08-02T11:55:40Z

README.md

+  - Additions that strictly improve objective, numerical quality criteria
+    (warning removal, speedup, better platform coverage, more parallelism, trap
+    more errors, etc.)


better platform coverage, more parallelism, trap more errors, etc.

better rephrase somewhat like "enhanced platform coverage, parallelism, errors trapping, etc."

Maria-Nosyk · 2017-08-02T11:57:33Z

README.md

+    more errors, etc.)
+  - Additions only likely to be _noticed by_ other developers-of-exonum,
+    invisible to users-of-exonum.


Additions are only likely...

Maria-Nosyk · 2017-08-02T12:04:08Z

README.md

+[Before creating an RFC]: #before-creating-an-rfc
+
+A hastily-proposed RFC can hurt its chances of acceptance. Low quality


A hastily-proposed RFC can hurt its chances of acceptance.

A hastily-proposed RFC can abate chances of its acceptance.

Maria-Nosyk · 2017-08-02T12:06:20Z

README.md

+Although there is no single way to prepare for submitting an RFC, it is
+generally a good idea to pursue feedback from other project developers
+beforehand, to ascertain that the RFC may be desirable; having a consistent


beforehand, to ascertain that
eliminate ","

Maria-Nosyk · 2017-08-02T13:05:28Z

README.md

+  - Fork the RFC repo [RFC repository]
+  - Copy `0000-template.md` to `text/0000-my-feature.md` (where "my-feature" is
+    descriptive. don't assign an RFC number yet).


don't assign an RFC number yet

"Don't"; eliminate "an"; better "just yet"

Maria-Nosyk · 2017-08-02T13:13:44Z

README.md

+    feedback from the larger community, and the author should be prepared to
+    revise it in response.
+  - Build consensus and integrate feedback. RFCs that have broad support are


a broad support

Maria-Nosyk · 2017-08-02T13:19:50Z

README.md

+      - This step is taken when enough of the tradeoffs have been discussed that
+        the maintainers of related repositories are in a position to make a
+        decision. That does not require consensus amongst all participants in the


enough of the tradeoffs -->

enough tradeoffs

that the maintainers of related repositories are in a position to make a decision. -->

and the maintainers of the related repositories are in position to make the decision.

Maria-Nosyk · 2017-08-02T13:21:30Z

README.md

+        the disposition on the RFC needs to have already been clearly articulated,
+        and there should not be a strong consensus *against* that position.
+        Maintainers of related repositories use their best judgment in taking this


Maintainers of related repositories -->

The maintainers of the related repositories

Maria-Nosyk · 2017-08-02T13:23:50Z

README.md

+        and major tradeoffs/points of disagreement.
+      - Before actually entering FCP, *all* maintainers of related repositories
+        must sign off.


all maintainers of related repositories must sign off -->

the maintainers of the related repositories

Maria-Nosyk · 2017-08-02T13:24:29Z

README.md

+      days. This way all
+      stakeholders have a chance to lodge any final objections before a decision
+      is reached.


before a decision is reached. -->

the decision

Maria-Nosyk · 2017-08-02T15:29:56Z

README.md

+team uses for all issues in the Exonum repository.
+
+The author of an RFC is not obligated to implement it. Of course, the RFC


an RFC --> the RFC

Maria-Nosyk · 2017-08-02T15:34:38Z

README.md

+is "no", then the appropriate response is to close the RFC, not postpone it.)
+
+## Help this is all too informal!


IMO "Help! This...." looks better

Maria-Nosyk · 2017-08-02T15:35:02Z

README.md

+  - [Implementing an RFC]
+  - [RFC Postponement]
+  - [Help this is all too informal!]


IMO "Help! This...." looks better

Maria-Nosyk · 2017-08-02T15:37:32Z

README.md

+Some changes do not require an RFC:
+
+  - Rephrasing, reorganizing, refactoring, or otherwise "changing shape does


otherwise --> "in other words"

Maria-Nosyk · 2017-08-02T15:38:37Z

README.md

+    poorly-received.
+  - Submit a pull request. As a pull request the RFC will receive design
+    feedback from the larger community, and the author should be prepared to


the larger community -->

a larger...

oudod requested review from defuz, alexauroradev, VukW, YuryYa, slowli and Maria-Nosyk July 24, 2017 14:04

alexauroradev reviewed Jul 25, 2017

View reviewed changes

alexauroradev approved these changes Jul 26, 2017

View reviewed changes

slowli reviewed Jul 27, 2017

View reviewed changes

Oleksii Udod added 7 commits July 28, 2017 14:28

describe RFC process

5eda314

Add license info

e6a5b43

Add substantial change examples

e45eeb8

Add conditions for merging RFC

95bd770

Fix nitpicks

45fe53c

Change license to dual MIT/Apache-2.0

053da31

Clarify merge procedure

e0d3533

Maria-Nosyk reviewed Aug 2, 2017

View reviewed changes

Fix language

8dccc0c

oudod merged commit 09fe9e1 into exonum:master Aug 3, 2017

oudod deleted the readme branch August 16, 2017 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Describe RFC process #1

Describe RFC process #1

oudod commented Jul 24, 2017 •

edited

Loading

alexauroradev left a comment

alexauroradev left a comment

slowli left a comment

slowli Jul 27, 2017

oudod Jul 28, 2017

slowli Jul 27, 2017

slowli Jul 27, 2017

slowli Jul 27, 2017

slowli Jul 27, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017 •

edited

Loading

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

Maria-Nosyk Aug 2, 2017

		[Exonum RFCs]: #exonum-rfcs

		Exonum RFC process is partially derived from [the Rust RFC process](https://github.com/rust-lang/rfcs/blob/master/README.md)

		request.

		Maintainers of related repositories makes final decisions about RFCs after the


		[RFC issue tracker]: https://github.com/exonum/rfcs/issues
		[RFC repository]: https://github.com/exonum/rfcs


		The Exonum RFCs are licensed under the Creative Commons Non-Commercial
		Share-Alike International License (version 4.0).


		The "RFC" (request for comments) process is intended to provide a consistent
		and controlled path for new features to enter the Exonum, so that all

		[Before creating an RFC]: #before-creating-an-rfc

		A hastily-proposed RFC can hurt its chances of acceptance. Low quality

		team uses for all issues in the Exonum repository.

		The author of an RFC is not obligated to implement it. Of course, the RFC

		is "no", then the appropriate response is to close the RFC, not postpone it.)

		## Help this is all too informal!

		Some changes do not require an RFC:

		- Rephrasing, reorganizing, refactoring, or otherwise "changing shape does

Describe RFC process #1

Describe RFC process #1

Conversation

oudod commented Jul 24, 2017 • edited Loading

alexauroradev left a comment

Choose a reason for hiding this comment

alexauroradev left a comment

Choose a reason for hiding this comment

slowli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Maria-Nosyk Aug 2, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oudod commented Jul 24, 2017 •

edited

Loading

Maria-Nosyk Aug 2, 2017 •

edited

Loading