Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading an exported instance snapshot #27

Merged
merged 4 commits into from
May 3, 2023

Conversation

sternik
Copy link
Contributor

@sternik sternik commented Apr 19, 2023

Hello team, this is a proposal to add a step to download an exported instance snapshot. In our process, we would like to upload the downloaded snapshot, e.g. to SOS, and then we will be able to use it to register the template on another account.

@sternik sternik marked this pull request as ready for review May 2, 2023 11:41
@yannprvst
Copy link

Hi @sternik !

Thank you for your proposal & contribution about our packer plugin.
For complete it, could you add the proper test file related to the snapshot download step (like https://github.com/exoscale/packer-plugin-exoscale/blob/main/builder/exoscale/step_export_snapshot_test.go for example) ?

Many thanks !

Copy link
Contributor

@exo-cedric exo-cedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sternik,

Thank you for this contribution! In addition to @yannprvst request, here are a few nitpicks which may be worth considering.

Cheers

builder/exoscale/step_download_snapshot.go Outdated Show resolved Hide resolved
builder/exoscale/step_download_snapshot.go Outdated Show resolved Hide resolved
builder/exoscale/step_download_snapshot.go Outdated Show resolved Hide resolved
docs/builders/exoscale.md Show resolved Hide resolved
sternik and others added 3 commits May 2, 2023 17:56
Co-authored-by: Cédric Dufour @ Exoscale <52404108+exo-cedric@users.noreply.github.com>
@sternik
Copy link
Contributor Author

sternik commented May 2, 2023

Thank you for your proposal & contribution about our packer plugin. For complete it, could you add the proper test file related to the snapshot download step (like main/builder/exoscale/step_export_snapshot_test.go for example) ?

Hi @yannprvst , test added -> 54aad16 (#27)

@exo-cedric
Copy link
Contributor

Thanks @sternik

I'm now working on integrating this in our acceptance tests and will get back to you.

Copy link
Contributor

@exo-cedric exo-cedric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated acceptance tests pass (which I'll PR and merge separately).
Thanks again for this contribution!

@exo-cedric exo-cedric merged commit eafb147 into exoscale:main May 3, 2023
@sternik sternik deleted the download_snapshot_step branch May 3, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants