Fix and improve auto update #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings, update `electron-builder` and `electron-builder-notarize` dependencies
…o enable a debug mode (that set log level to debug) or display log folders, to make support easier.
…llow to check for update and trigger app update if needed, before showing login page.
fdaveine
commented
Nov 2, 2020
|
@antoinelibert to review plz |
…uilder debug mode is not enabled
… event listener were setup by `SplashScreenPage.vue` > `mounted`, add catch block for unhandled exception coming from `autoUpdater.checkForUpdates()` in `src/main/index.js`
antoinelibert
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Altto show it) which allow user to find log files easily and to enable DEBUG (log level) modeUseful links:
https://stackoverflow.com/questions/51003995/how-can-i-test-electron-builder-auto-update-flow
electron-userland/electron-builder#3053
electron-userland/electron-builder#3753 (comment)
electron-userland/electron-builder#1505
electron-userland/electron-builder#2521 (comment)