Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TEST_DIR management #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed TEST_DIR management #83

wants to merge 1 commit into from

Conversation

c4s4
Copy link

@c4s4 c4s4 commented Sep 26, 2016

TEST_DIR was set in script even if already set in environment. Added a test so that it is not set if already defined.

@cirulls
Copy link

cirulls commented Sep 28, 2016

thanks @c4s4, that's a useful feature. As you submitted the pull request to my fork as well, I added my comments in there: xspec#11

@cirulls
Copy link

cirulls commented Sep 29, 2016

I merged this pull request in my fork and add a bats unit test testing that TEST_DIR is overridden when provided externally.

cirulls referenced this pull request in xspec/xspec Oct 18, 2016
- allow to set a custom location of TEST_DIR for HTML reports on batch script (in line with #83)
- fix error message on batch script for opening HTML report (#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants