Escape more special chars with comprehensive test

expelledboy · Dec 14, 2023 · 0cd66cb · 0cd66cb
1 parent 08d30ac
commit 0cd66cb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/erl2json.erl b/src/erl2json.erl
@@ -95,6 +95,8 @@ encode_nested(Map) when is_map(Map) ->
 
 %% --
 
+% https://www.erlang.org/doc/reference_manual/data_types#escape-sequences
+
 escape(List) when is_list(List) ->
     escape(<<>>, list_to_binary(List));
 escape(Binary) when is_binary(Binary) ->
@@ -105,9 +107,11 @@ escape(Acc, <<>>) ->
 escape(Acc, Binary) ->
     case Binary of
         <<"\b", Rest/binary>> -> escape(<<Acc/binary, "\\\\b">>, Rest);
+        <<"\e", Rest/binary>> -> escape(<<Acc/binary, "\\\\e">>, Rest);
         <<"\f", Rest/binary>> -> escape(<<Acc/binary, "\\\\f">>, Rest);
         <<"\n", Rest/binary>> -> escape(<<Acc/binary, "\\\\n">>, Rest);
         <<"\r", Rest/binary>> -> escape(<<Acc/binary, "\\\\r">>, Rest);
+        <<"\s", Rest/binary>> -> escape(<<Acc/binary, "\\\\s">>, Rest);
         <<"\t", Rest/binary>> -> escape(<<Acc/binary, "\\\\t">>, Rest);
         <<"\v", Rest/binary>> -> escape(<<Acc/binary, "\\\\v">>, Rest);
         <<Char, Rest/binary>> -> escape(<<Acc/binary, Char>>, Rest)

diff --git a/test/bin.bats b/test/bin.bats
@@ -50,4 +50,22 @@ setup() {
 
     run bash -o pipefail -c "echo '\"\\n\"' | $BIN | jq empty"
     assert_success
+
+    chars=(
+        '\b'
+        '\e'
+        '\f'
+        '\n'
+        '\r'
+        '\s'
+        '\t'
+        '\v'
+    )
+
+    for char in "${chars[@]}"; do
+        echo "\"$char\""
+        echo "\"\\$char\""
+        output=$(echo "\"$char\"" | $BIN)
+        assert_equal "$output" "\"\\$char\""
+    done
 }