Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected some surveys #65

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

corrected some surveys #65

wants to merge 1 commit into from

Conversation

IanEisenberg
Copy link
Member

No description provided.

@vsoch vsoch mentioned this pull request Nov 15, 2017
Closed
@vsoch
Copy link
Member

vsoch commented Nov 15, 2017

Thanks @IanEisenberg ! I'm also going to update these in their (respective individuals repos) and I'll re-push the vanessa/expfactory-surveys container. Also keep a look out for illegal characters in these files - the biggest issue I had with converting the survey.tsv were a bunch of non ascii characters (eg, the "..." character, "fi" and quotes and commas) that likely came from copy pasting from some internet place.

@vsoch
Copy link
Member

vsoch commented Nov 15, 2017

Changes look good, LGTM, feel free to merge (or add more). I've fixed v2 branches as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanEisenberg @vsoch