Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aspect_critique documentation #1382

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: aspect_critique documentation #1382

merged 1 commit into from
Sep 30, 2024

Conversation

jjmachan
Copy link
Member

@jjmachan jjmachan commented Sep 30, 2024 •
edited
Loading

fixes #1374

but a couple of things to note here

  • metrics should exposed from ragas.metrics because all our metrics modules are private with _ prefix.
  • need to mention this in the migration guide, about aspect critic

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 30, 2024
shahules786
shahules786 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other parts same mistake was done. I'll correct it before release.

@shahules786 shahules786 merged commit 9b4742a into explodinggradients:main Sep 30, 2024
5 checks passed
shahules786 pushed a commit to shahules786/ragas that referenced this pull request Oct 1, 2024
@jjmachan @shahules786
fix: aspect_critique documentation (explodinggradients#1382)
ce1c028 
fixes explodinggradients#1374 

but a couple of things to note here
- metrics should exposed from `ragas.metrics` because all our metrics
modules are private with `_` prefix.
- need to mention this in the migration guide, about aspect critic
shahules786 pushed a commit to shahules786/ragas that referenced this pull request Oct 2, 2024
@jjmachan @shahules786
fix: aspect_critique documentation (explodinggradients#1382)
bf2cc55 
fixes explodinggradients#1374 

but a couple of things to note here
- metrics should exposed from `ragas.metrics` because all our metrics
modules are private with `_` prefix.
- need to mention this in the migration guide, about aspect critic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahules786 shahules786 shahules786 approved these changes

Assignees
No one assigned
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No module named 'ragas.metrics.critique'
2 participants
@jjmachan @shahules786