Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce epsilon in denominators to avoid division by zero #1622

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jltham
Copy link
Contributor

@jltham jltham commented Nov 5, 2024

This only affects src/ragas/_topic_adherece.py.

Previously, it can be complicated to handle the score given by this metric due to possibility of division by zero. I propose to introduce an epsilon in the denominator to avoid that case.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@shahules786 shahules786 self-requested a review November 5, 2024 05:40
Copy link
Member

@shahules786 shahules786 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks buddy :)

@shahules786 shahules786 merged commit 2a4a5ad into explodinggradients:main Nov 5, 2024
16 checks passed
shahules786 pushed a commit to shahules786/ragas that referenced this pull request Nov 6, 2024
…ggradients#1622)

This only affects `src/ragas/_topic_adherece.py`.

Previously, it can be complicated to handle the score given by this
metric due to possibility of division by zero. I propose to introduce an
epsilon in the denominator to avoid that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants