Skip to content

Conversation

@yesidc
Copy link
Contributor

@yesidc yesidc commented Mar 27, 2025

Description
This update refactors the provided examples incorporating the corresponding async blocks. The changes enable the code to be executed seamlessly without any further modifications.

Key Changes:
Asynchronous Functionality: Wrapped relevant code in an async def function, allowing for proper asynchronous execution. This eliminates any runtime issues associated with unhandled asynchronous operations.

Evaluator LLM Initialization: Clearly demonstrates the creation of the evaluator_llm object using the LangchainLLMWrapper with the ChatOpenAI model set to gpt-4o. This change improves clarity as the setup of the evaluator was previously not self-explanatory.

Code Readability: Improved formatting and organization of import statements for better readability and maintainability.

…de can be run without any further modifications. It clearly shows how the evaluator_llm object is created (which is not self explanatory)
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@yesidc
Copy link
Contributor Author

yesidc commented Mar 27, 2025

This issue occurs across several parts of the documentation, and it seems to be very confusing, e.g., issue #1925 issue #1939

Copy link
Member

@anistark anistark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @yesidc

@anistark anistark merged commit c8efc32 into explodinggradients:main Sep 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants