Skip to content

docs: agent metrics code examples improvement #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yesidc
Copy link

@yesidc yesidc commented Mar 27, 2025

Description
This update refactors the provided examples incorporating the corresponding async blocks. The changes enable the code to be executed seamlessly without any further modifications.

Key Changes:
Asynchronous Functionality: Wrapped relevant code in an async def function, allowing for proper asynchronous execution. This eliminates any runtime issues associated with unhandled asynchronous operations.

Evaluator LLM Initialization: Clearly demonstrates the creation of the evaluator_llm object using the LangchainLLMWrapper with the ChatOpenAI model set to gpt-4o. This change improves clarity as the setup of the evaluator was previously not self-explanatory.

Code Readability: Improved formatting and organization of import statements for better readability and maintainability.

…de can be run without any further modifications. It clearly shows how the evaluator_llm object is created (which is not self explanatory)
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 27, 2025
@yesidc
Copy link
Author

yesidc commented Mar 27, 2025

This issue occurs across several parts of the documentation, and it seems to be very confusing, e.g., issue #1925 issue #1939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant