Issue #456: Use of Django connection name rather than alias as lookup #458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes connection behavior from storing the database
connection name to using the database alias mapped by SQL Explorer
instead.
The reason for this change is two-fold:
Django connection names to query those databases, even if SQL
does not expose the connection directly.
Query
stores the connection name, which means that if theDjango connection name changes or a different connection should
be used (for example, one with reduced permissions) the stored
Query will either stop working or at least continue using the old
connection
This change modifies
ExplorerConnections
from being a dictionarythat proxies the Django connection dictionary to a dictionary-like
object that uses
EXPLORER_CONNECTIONS
to lookup and validatethe requested connection alias.
In addition all code that used to the
EXPLORER_CONNECTIONS
valuenow uses the key instead.
For backwards compatibility, a migration will back-populate the alias
into
Query
instances (and fail if the mapping no longer exists),EXPLORER_DEFAULT_CONNECTION
is re-written on start-up to use thealias in case it still uses the Django Connection name and
ExplorerConnections
will still accept a Django Connection name aslong as that name is exposed by some alias in
EXPLORER_CONNECTIONS
.