Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add frozen structures #28

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

bdura
Copy link
Contributor

@bdura bdura commented May 16, 2023

This PR adds frozen data structures present in spaCy and Weasel factor them into confection.

@rmitsch
Copy link
Contributor

rmitsch commented May 16, 2023

What's the motivation to do so?

@bdura
Copy link
Contributor Author

bdura commented May 16, 2023

What's the motivation to do so?

As discussed on Missive, the goal is to avoid redefining the same frozen components in multiple places and confection seemed like a good place for it to land.

@bdura bdura merged commit 371b97d into explosion:main May 16, 2023
@bdura bdura deleted the feat/add-frozen-structures branch May 16, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants