-
Notifications
You must be signed in to change notification settings - Fork 1
Fix MacOS Intel runners #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cibuildwheel.yml
Outdated
| os: | ||
| - ubuntu-latest # Intel | ||
| - ubuntu-24.04-arm # ARM | ||
| - windows-latest # Intel | ||
| - windows-11-arm # ARM | ||
| - macos-15-intel # Intel | ||
| - macos-latest # ARM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example file looks severely obsolete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going by the commit log, I think this file and the publish_pypy.yml files were accidentally left here when the "real" files were moved to .github/workflows.
I'd just delete both of them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publish_pypy was never moved though.
A proper cleanup looks very messy and beyond the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just delete this file? Either way it's not worth updating like you have it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just reverted the changes in this PR to keep a clean git history.
README.md
Outdated
| uses: explosion/gha-cibuildwheel/cibuildwheel.yml@main | ||
| with: | ||
| os-matrix: '["ubuntu-latest", "windows-latest", "macos-13", "macos-14", "ubuntu-24.04-arm"]' | ||
| os-matrix: '["ubuntu-latest", "ubuntu-24.04-arm", "windows-latest", "windows-11-arm", "macos-15-intel", "macos-latest"]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks obsolete.
I found no trace of this os-matrix setting. It's hardcoded in .github/workflows/cibuildwheel.yml:113.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the docs were added in 1b1ad35, which has the message "Add LLM docs" so it was probably hallucinated.
macos-13runners have been retired and replaced bymacos-15-intel.