Merge pull request #9596 from adrianeboyd/tests/reenable-v3.2.0-tests

Reenable tests for v3.2.0
explosion · Nov 5, 2021 · 0fc3dee · 0fc3dee
2 parents 5cdb7eb + c155f33
commit 0fc3dee
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/.github/azure-steps.yml b/.github/azure-steps.yml
@@ -65,11 +65,8 @@ steps:
  condition: eq(${{ parameters.gpu }}, true)
 
  - script: |
- #python -m spacy download ca_core_news_sm
- #python -m spacy download ca_core_news_md
- # temporarily install the v3.1.0 models
- pip install --no-deps https://github.com/explosion/spacy-models/releases/download/ca_core_news_sm-3.1.0/ca_core_news_sm-3.1.0-py3-none-any.whl
- pip install --no-deps https://github.com/explosion/spacy-models/releases/download/ca_core_news_md-3.1.0/ca_core_news_md-3.1.0-py3-none-any.whl
+ python -m spacy download ca_core_news_sm
+ python -m spacy download ca_core_news_md
  python -c "import spacy; nlp=spacy.load('ca_core_news_sm'); doc=nlp('test')"
  displayName: 'Test download CLI'
  condition: eq(variables['python_version'], '3.8')
@@ -98,8 +95,7 @@ steps:
 
  - script: |
  python -c "import spacy; config = spacy.util.load_config('ner.cfg'); config['components']['ner'] = {'source': 'ca_core_news_sm'}; config.to_disk('ner_source_sm.cfg')"
- # temporarily ignore W095
- PYTHONWARNINGS="error,ignore:[W095]:UserWarning,ignore::DeprecationWarning" python -m spacy assemble ner_source_sm.cfg output_dir
+ PYTHONWARNINGS="error,ignore::DeprecationWarning" python -m spacy assemble ner_source_sm.cfg output_dir
  displayName: 'Test assemble CLI'
  condition: eq(variables['python_version'], '3.8')
 

diff --git a/spacy/tests/test_cli.py b/spacy/tests/test_cli.py
@@ -492,7 +492,6 @@ def test_string_to_list_intify(value):
  assert string_to_list(value, intify=True) == [1, 2, 3]
 
 
-@pytest.mark.skip(reason="Temporarily skip until v3.2.0 release")
 def test_download_compatibility():
  spec = SpecifierSet("==" + about.__version__)
  spec.prereleases = False
@@ -503,7 +502,6 @@ def test_download_compatibility():
  assert get_minor_version(about.__version__) == get_minor_version(version)
 
 
-@pytest.mark.skip(reason="Temporarily skip until v3.2.0 release")
 def test_validate_compatibility_table():
  spec = SpecifierSet("==" + about.__version__)
  spec.prereleases = False